Igor Lvovsky has uploaded a new change for review.
Change subject: Fix broken APIs: hotplugDisk, hotunplugDisk, migrateCancel ......................................................................
Fix broken APIs: hotplugDisk, hotunplugDisk, migrateCancel
Change-Id: I1316887b307c6a2ddb3b0220c40b89d2c891c213 --- M vdsm/API.py 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/1387/1 -- To view, visit http://gerrit.ovirt.org/1387 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I1316887b307c6a2ddb3b0220c40b89d2c891c213 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Fix broken APIs: hotplugDisk, hotunplugDisk, migrateCancel ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/1387 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1316887b307c6a2ddb3b0220c40b89d2c891c213 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Adam Litke has posted comments on this change.
Change subject: Fix broken APIs: hotplugDisk, hotunplugDisk, migrateCancel ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Yes, this is obviously correct.
-- To view, visit http://gerrit.ovirt.org/1387 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1316887b307c6a2ddb3b0220c40b89d2c891c213 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Fix broken APIs: hotplugDisk, hotunplugDisk, migrateCancel ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1387 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1316887b307c6a2ddb3b0220c40b89d2c891c213 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Fix broken APIs: hotplugDisk, hotunplugDisk, migrateCancel ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1387 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I1316887b307c6a2ddb3b0220c40b89d2c891c213 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix broken APIs: hotplugDisk, hotunplugDisk, migrateCancel ......................................................................
Fix broken APIs: hotplugDisk, hotunplugDisk, migrateCancel
Change-Id: I1316887b307c6a2ddb3b0220c40b89d2c891c213 --- M vdsm/API.py 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: Adam Litke: Looks good to me, but someone else must approve Saggi Mizrahi: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Igor Lvovsky: Verified
-- To view, visit http://gerrit.ovirt.org/1387 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I1316887b307c6a2ddb3b0220c40b89d2c891c213 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org