From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: logUtils: Move logUtils module to vdsm.common
......................................................................
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/76919/9/vdsm.spec.in
File vdsm.spec.in:
Line 803: # So Remove them if it is played with /etc/sysctl.conf.
Line 804: if grep -q "# VDSM section begin" /etc/sysctl.conf; then
Line 805: /bin/sed -i '/# VDSM section begin/,/# VDSM section end/d' \
Line 806: /etc/sysctl.conf
Line 807: fi
quite yucky but you could add
# REQUIRED_FOR upgrade from vdsm<=4.19
grep -q vdsm.logUtils /etc/vdsm/logger.conf && sed -i
s/vdsm.logUtils/vdsm.common.logutils/ /etc/vdsm/logger.conf
to allow upgrade of folks who edited that file.
Line 808:
Line 809: # VDSM installs vdsm-modules-load.d.conf file - the following command will
Line 810: # refresh vdsm kernel modules requirements to start on boot
Line 811: /bin/systemctl restart systemd-modules-load.service >/dev/null 2>&1 ||
:
--
To view, visit
https://gerrit.ovirt.org/76919
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic642205e3d5515acfeb607bb5dcad24f699d286f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes