Change in vdsm[master]: change misc.retry to make it more general

Royce Lv has uploaded a new change for review.

Change subject: change misc.retry to make it more general
......................................................................

change misc.retry to make it more general

add argument list to misc.retry to make it usable for function
with arguments.

Change-Id: I2b7d87629762d4d8f248d50fa4da71a0af3645d8
Signed-off-by: Royce Lv 
---
M vdsm/storage/misc.py
M vdsm/supervdsm.py
2 files changed, 4 insertions(+), 3 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/4032/1
--
To view, visit http://gerrit.ovirt.org/4032
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b7d87629762d4d8f248d50fa4da71a0af3645d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: change misc.retry to make it more general
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

I like this generalization of misc.retry(), but I'm asking for more ;-)

....................................................
File vdsm/storage/misc.py
Line 737: def retry(func, argList=[], expectedException=Exception, tries=None,
it is usually called just "args".
consider adding kwargs, too, to make it even more general.

--
To view, visit http://gerrit.ovirt.org/4032
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7d87629762d4d8f248d50fa4da71a0af3645d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: change misc.retry to make it more general
......................................................................

Patch Set 1: No score

Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/121/

--
To view, visit http://gerrit.ovirt.org/4032
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7d87629762d4d8f248d50fa4da71a0af3645d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: change misc.retry to make it more general
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/121/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/4032
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7d87629762d4d8f248d50fa4da71a0af3645d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server

Royce Lv has abandoned this change.

Change subject: change misc.retry to make it more general
......................................................................

Patch Set 1: Abandoned

--
To view, visit http://gerrit.ovirt.org/4032
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2b7d87629762d4d8f248d50fa4da71a0af3645d8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Shu Ming 
Gerrit-Reviewer: oVirt Jenkins CI Server