Change in vdsm[master]: sampling: Rename stats_flags variable

Ala Hino has uploaded a new change for review.

Change subject: sampling: Rename stats_flags variable
......................................................................

sampling: Rename stats_flags variable

Rename 'stats_flags' to 'stats' to reflect the exact meaning of this
varaiable based on libvirt documentation. There is an additional
'falg' variable that is used to retrieve additionals stats, for
example: VIR_CONNECT_GET_ALL_DOMAINS_STATS_BACKING that will be used
in a future patch.

Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd
Signed-off-by: Ala Hino <ahino(a)redhat.com&gt;
---
M lib/vdsm/virt/sampling.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/60862/1

diff --git a/lib/vdsm/virt/sampling.py b/lib/vdsm/virt/sampling.py
index 4cfd3b1..8feaf37 100644
--- a/lib/vdsm/virt/sampling.py
+++ b/lib/vdsm/virt/sampling.py
@@ -475,11 +475,11 @@
 
 class VMBulkSampler(object):
     def __init__(self, conn, get_vms, stats_cache,
-                 stats_flags=0, ttl=_TTL):
+                 stats=0, ttl=_TTL):
         self._conn = conn
         self._get_vms = get_vms
         self._stats_cache = stats_cache
-        self._stats_flags = stats_flags
+        self._stats = stats
         self._skip_doms = ExpiringCache(ttl)
         self._sampling = threading.Semaphore()  # used as glorified counter
         self._log = logging.getLogger("virt.sampling.VMBulkSampler")
@@ -496,14 +496,14 @@
             if fast_path:
                 # This is expected to be the common case.
                 # If everything's ok, we can skip all the costly checks.
-                bulk_stats = self._conn.getAllDomainStats(self._stats_flags)
+                bulk_stats = self._conn.getAllDomainStats(self._stats)
             else:
                 # A previous call got stuck, or not every domain
                 # has properly recovered. Thus we must whitelist domains.
                 doms = self._get_responsive_doms()
                 if doms:
                     bulk_stats = self._conn.domainListGetStats(
-                        doms, self._stats_flags)
+                        doms, self._stats)
                 else:
                     bulk_stats = []
         except Exception:


-- 
To view, visit https://gerrit.ovirt.org/60862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: sampling: Rename stats_flags variable
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Francesco Romani has posted comments on this change.

Change subject: sampling: Rename stats_flags variable
......................................................................


Patch Set 1: Code-Review-1

Not sure about this. What you state is technically correct, but I find the naming choice
from libvirt unfortunate on the first place.

-- 
To view, visit https://gerrit.ovirt.org/60862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

gerrit-hooks has posted comments on this change.

Change subject: sampling: Rename stats_flags variable
......................................................................


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/60862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

Ala Hino has abandoned this change.

Change subject: sampling: Rename stats_flags variable
......................................................................


Abandoned

Based on Francesco comment, this is by design

-- 
To view, visit https://gerrit.ovirt.org/60862
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iaca95656038489f1ce4286e32ab819d78b9524dd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;