10:55 a.m.
Adam Litke has uploaded a new change for review.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
virt: Resolve snapshot type after prepareVolumePath
The Drive.blockDev property depends on the presence of the volume path
locally. Therefore, it is not safe to call until after the new snapshot
volume path has been prepared. Use a lambda function to delay the call
until the information is needed.
Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Signed-off-by: Adam Litke <alitke(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/32066/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c157e4c..ff69488 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4011,7 +4011,10 @@
newDrives[vmDevName]["poolID"] = vmDrive.poolID
newDrives[vmDevName]["name"] = vmDevName
newDrives[vmDevName]["format"] = "cow"
- snapTypes[vmDevName] = ('file', 'block')[vmDrive.blockDev]
+
+ # We cannot evaluate blockDev until after prepareVolumePath
+ snapTypes[vmDevName] = \
+ lambda: 'block' if vmDrive.blockDev else 'file'
# If all the drives are the current ones, return success
if len(newDrives) == 0:
@@ -4035,7 +4038,7 @@
return errCode['snapshotErr']
snapelem = _diskSnapshot(vmDevName, newDrives[vmDevName]["path"],
- snapTypes[vmDevName])
+ snapTypes[vmDevName]())
disks.appendChild(snapelem)
snap.appendChild(disks)
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
11:47 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5779/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/145/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3938/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1804/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11:37 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
virt: Resolve snapshot type after prepareVolumePath
The Drive.blockDev property depends on the presence of the volume path
locally. Therefore, it is not safe to call until after the new snapshot
volume path has been prepared. Use a lambda function to delay the call
until the information is needed.
Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32066
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Adam Litke: Verified
Federico Simoncelli: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
8:42 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11242/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12184/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12031/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1599/ : There was an
infra issue, please contact infra(a)ovirt.org
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:56 a.m.
Federico Simoncelli has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 3: Code-Review+2
Nice I like this better than the previous patch set!
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
7:53 a.m.
Francesco Romani has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:57 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11207/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12149/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11996/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1589/ : There was an
infra issue, please contact infra(a)ovirt.org
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:38 a.m.
Adam Litke has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
8:40 a.m.
Adam Litke has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32066/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3979: newDrives[vmDevName]["format"] = "cow"
Line 3980:
Line 3981: # We cannot evaluate blockDev until after prepareVolumePath
Line 3982: snapTypes[vmDevName] = \
Line 3983: lambda: 'block' if vmDrive.blockDev else
'file'
To make things more explicit. I think is clearer if we add another
dictiona
Good idea and done in the next series.
Line 3984:
Line 3985: # If all the drives are the current ones, return success
Line 3986: if len(newDrives) == 0:
Line 3987: self.log.debug('all the drives are already in use,
success')
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
6:18 a.m.
Francesco Romani has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32066/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3979: newDrives[vmDevName]["format"] = "cow"
Line 3980:
Line 3981: # We cannot evaluate blockDev until after prepareVolumePath
Line 3982: snapTypes[vmDevName] = \
Line 3983: lambda: 'block' if vmDrive.blockDev else
'file'
I'm missing something.
To make things more explicit. I
think is clearer if we add another dictionary/cache which maps vmDevName - which we'll
have down on line 4007 when we need this value to the relevant vmDrive:
drives[vmDevName] = vmDrive
So in line 4007 we can just write
snapelem = _diskSnapshot(vmDevName,
newDrives[vmDevName]["path"],
"block" if drives[vmDevName].blockDev else
"file")
I think this is a bit better than juggling with lambdas.
What do you think?
Line 3984:
Line 3985: # If all the drives are the current ones, return success
Line 3986: if len(newDrives) == 0:
Line 3987: self.log.debug('all the drives are already in use,
success')
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
6:05 a.m.
Francesco Romani has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32066/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3979: newDrives[vmDevName]["format"] = "cow"
Line 3980:
Line 3981: # We cannot evaluate blockDev until after prepareVolumePath
Line 3982: snapTypes[vmDevName] = \
Line 3983: lambda: 'block' if vmDrive.blockDev else
'file'
I'm missing something.
Looks like this field is not used until line 4007.
Can't we just avoid to set this field (maybe setting a placeholder instead) until it
is safe to do so - at line 4006 or something like it?
Line 3984:
Line 3985: # If all the drives are the current ones, return success
Line 3986: if len(newDrives) == 0:
Line 3987: self.log.debug('all the drives are already in use,
success')
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
2:28 p.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11196/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12138/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11985/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1583/ : There was an
infra issue, please contact infra(a)ovirt.org
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
12:49 p.m.
Adam Litke has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 1:
There is not really a better way. The other approach would be to pass a reference to the
drive object in the newDrives dict. Then we'd have to pop it back off in the loop
below to avoid confusing methods which don't expect it to be there.
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
2:16 p.m.
Francesco Romani has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 1:
this is a bit surprising. Seems a clever solution, but feels a bit hackish. Any chance to
improve the code to make it simpler, while still correct?
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
11:41 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11173/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12115/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11962/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/1580/ : There was an
infra issue, please contact infra(a)ovirt.org
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:56 a.m.
Adam Litke has posted comments on this change.
Change subject: virt: Resolve snapshot type after prepareVolumePath
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/32066
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4726702eb329bf65f1f9c658067f7a01c2179e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3545
days inactive
3551
days old
vdsm-patches@lists.fedorahosted.org
15 comments
5 participants
participants (5)
-
alitke＠redhat.com -
Dan Kenigsberg -
Federico Simoncelli -
fromani＠redhat.com -
Jenkins CI RO