Change in vdsm[master]: domainMonitor: Improve logging

[Nir Soffer]

Nir Soffer has uploaded a new change for review.

Change subject: domainMonitor: Improve logging
......................................................................

domainMonitor: Improve logging

We have logs in domain monitor thread, and we can see when a monitor
starts or stops, but we don't have any info which thread triggered the
operation.  This patch adds info level log messages when starting and
stopping domain monitoring, revealing the caller thread.

Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029
Relates-To: https://bugzilla.redhat.com/1032925
Signed-off-by: Nir Soffer 
---
M vdsm/storage/domainMonitor.py
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/04/21904/1

diff --git a/vdsm/storage/domainMonitor.py b/vdsm/storage/domainMonitor.py
index 5b0d4ac..30928dd 100644
--- a/vdsm/storage/domainMonitor.py
+++ b/vdsm/storage/domainMonitor.py
@@ -98,6 +98,7 @@
             domainThread.poolDomain |= poolDomain
             return

+        self.log.info("Start monitoring %s", sdUUID)
         domainThread = DomainMonitorThread(weakref.proxy(self),
                                            sdUUID, hostId, self._interval)
         domainThread.poolDomain = poolDomain
@@ -111,6 +112,7 @@
         # Eg: when a domain is detached the domain monitor is stopped and
         # the host id is released. If the monitor didn't actually exit it
         # might respawn a new acquire host id.
+        self.log.info("Stop monitoring %s", sdUUID)
         try:
             self._domains[sdUUID].stop()
         except KeyError:
@@ -122,6 +124,7 @@
         return self._domains[sdUUID].getStatus()

def close(self):
+        self.log.info("Stopping domain monitors")
         for sdUUID in self._domains.keys():
             self.stopMonitoring(sdUUID)

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: domainMonitor: Improve logging
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5845/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5937/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5049/ : SUCCESS

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: domainMonitor: Improve logging
......................................................................

Patch Set 1: Verified+1

Sergey Gotliv has posted comments on this change.

Change subject: domainMonitor: Improve logging
......................................................................

Patch Set 1: Code-Review+1

This is exactly the same question I asked myself yesterday :-).

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: domainMonitor: Improve logging
......................................................................

Patch Set 1: Code-Review+1

Ohad Basan has posted comments on this change.

Change subject: domainMonitor: Improve logging
......................................................................

Patch Set 1: Code-Review+1

Ayal Baron has posted comments on this change.

Change subject: domainMonitor: Improve logging
......................................................................

Patch Set 1: Code-Review+2

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: domainMonitor: Improve logging
......................................................................

domainMonitor: Improve logging

We have logs in domain monitor thread, and we can see when a monitor
starts or stops, but we don't have any info which thread triggered the
operation.  This patch adds info level log messages when starting and
stopping domain monitoring, revealing the caller thread.

Change-Id: I20feb40b097fa65ebebf851e33c051fc184ff029
Relates-To: https://bugzilla.redhat.com/1032925
Signed-off-by: Nir Soffer 
Reviewed-on: http://gerrit.ovirt.org/21904
Reviewed-by: Sergey Gotliv 
Reviewed-by: Allon Mureinik 
Reviewed-by: Ohad Basan 
Reviewed-by: Ayal Baron 
---
M vdsm/storage/domainMonitor.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Ayal Baron: Looks good to me, approved
  Nir Soffer: Verified
  Sergey Gotliv: Looks good to me, but someone else must approve
  Ohad Basan: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, but someone else must approve