Change in vdsm[master]: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine
......................................................................

[WIP] - BZ752464 - register ovirt-node image to ovirt-engine

Change-Id: I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b
---
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/caps.py
M vdsm/storage/misc.py
A vdsm/vdsm-bash-functions
M vdsm/vdsm-store-net-config.in
M vdsm/vdsmd.in
M vdsm_hooks/persist-vdsm-hooks
M vdsm_reg/deployUtil.py.in
9 files changed, 53 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/268/1
--
To view, visit http://gerrit.ovirt.org/268
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has abandoned this change.

Change subject: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine Change-Id:
I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b
......................................................................


Patch Set 4: Abandoned

I am going to split these change into small patches.

--
To view, visit http://gerrit.ovirt.org/268
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine Change-Id:
I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(2 inline comments)

....................................................
Commit Message
Line 7: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine
linefeed missing before Change-Id

....................................................
File vdsm_reg/vdsm-reg-setup
Line 47:         # Set the registration URL accordingly with the hypervisor
finding the correct path seems like a job for a separate function, and certainly in
another patch.

but why do you need RHEVManagerWeb for 2.x host? note that such a host would still need to
connect to an upstream ovirt-engine

--
To view, visit http://gerrit.ovirt.org/268
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: [WIP] - BZ752464 - register ovirt-node image to ovirt-engine
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(5 inline comments)

....................................................
File vdsm_hooks/persist-vdsm-hooks
Line 9: . /usr/libexec/vdsm/vdsm-bash-fucntions
Macro. You probably need to rename the file (.in) and include it in the right sections in
Makefile.am.

....................................................
File vdsm/storage/misc.py
Line 1298:         OVIRT_NODE = os.path.exists('/etc/ovirt-node-image-release')
This is going to be executed only if the first os.path.exists raises an exceptions and not
when it just returns False.

....................................................
File vdsm/vdsmd.in
Line 24: . /usr/libexec/vdsm/vdsm-bash-functions
Use the macro here too.

Line 285:     if isOvirt && [ ! -f /etc/pki/vdsm/certs/vdsmcert.pem ]
If a macro wasn't used here, we should.

....................................................
File vdsm/vdsm-store-net-config.in
Line 6: . /usr/libexec/vdsm/vdsm-bash-functions
I believe we have a macro for the libexec vdsm path.

--
To view, visit http://gerrit.ovirt.org/268
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f251ad65b2d913f2da08e0f5101ab2340a2dc3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;