Change in vdsm[master]: NIC model should be converted from 'pv' to 'virtio'

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: NIC model should be converted from 'pv' to 'virtio'
......................................................................

NIC model should be converted from 'pv' to 'virtio'

Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/1732/1
--
To view, visit http://gerrit.ovirt.org/1732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: NIC model should be converted from 'pv' to 'virtio'
......................................................................


Patch Set 1:

>  have you considered if the opposite conversion, on the reporting
> flow, is required too? 
yes, I considered it, but I don't want intervene  in reporting flow and change things
there. The 'pv' exists only because backend has a problems with transferring to us
the right model type -'virtio' (but they will do it later) .
So, for now we decided that backend will convert it back if needed.

--
To view, visit http://gerrit.ovirt.org/1732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: NIC model should be converted from 'pv' to 'virtio'
......................................................................


Patch Set 1:

have you considered if the opposite conversion, on the reporting flow, is required too?

--
To view, visit http://gerrit.ovirt.org/1732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: NIC model should be converted from 'pv' to 'virtio'
......................................................................


NIC model should be converted from 'pv' to 'virtio'

Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
---
M vdsm/libvirtvm.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Igor Lvovsky: Verified


--
To view, visit http://gerrit.ovirt.org/1732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: NIC model should be converted from 'pv' to 'virtio'
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: NIC model should be converted from 'pv' to 'virtio'
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/1732
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78fc8abcc3bbcd85c17f10ccc4187cc92ada8159
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;