Saggi Mizrahi has uploaded a new change for review.
Change subject: Don't invalidate the lv on lvchange(). Activity is tested using device mapper anyway ......................................................................
Don't invalidate the lv on lvchange(). Activity is tested using device mapper anyway
Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 --- M vdsm/storage/lvm.py 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/675/1 -- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com
Eduardo has posted comments on this change.
Change subject: Don't invalidate the lv on lvchange(). Activity is tested using device mapper anyway ......................................................................
Patch Set 1: Do not submit
(1 inline comment)
.................................................... File vdsm/storage/lvm.py Line 800: rc, out, err = _lvminfo.cmd(cmd) You are changing the lvm cache concept. This is a low level function, why are you changing it? In addition this function is used for rw permissions.
-- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Don't invalidate the cache on lv activation ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Don't invalidate the cache on lv activation ......................................................................
Patch Set 3:
Edu please review again.
-- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Ayal Baron has posted comments on this change.
Change subject: BZ#769502 Don't invalidate the cache on lv activation ......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File vdsm/storage/lvm.py Line 731: changelv(vg, lvs, "--available", available, False) Problem here is that you also do this for deactivate which means that in the following flow we would have a problem: 1. activate (runVM for example) 2. deactivate (no invalidate) 3. spm makes changes 4. activate (no invalidate) - data is stale
-- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#769502 Don't invalidate the cache on lv activation ......................................................................
-- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#769502 Don't invalidate the cache on lv activation ......................................................................
Patch Set 6: (1 inline comment)
.................................................... File vdsm/storage/lvm.py Line 731: changelv(vg, lvs, "--available", available, False) That's just unrelated.
hsm.deactivate hsm.some_operation_ that_ refreshes_the_cache spm.change hsm.activate
You are still stale. Just refreshing manicly isn't the way to fix this issue. To find a FAST way to check if the cache is stale (gen number on the VG anyone?) is the way to mediate this and it is still not race proof.
-- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has abandoned this change.
Change subject: BZ#769502 Don't invalidate the cache on lv activation ......................................................................
Patch Set 8: Abandoned
-- To view, visit http://gerrit.ovirt.org/675 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I73981f8aa82994333caf338c94ebfb8113280329 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org