Change in vdsm[master]: switch engine plugin to use system() instead of os.system to...

[Joey Boggs]

Joey Boggs has uploaded a new change for review.

Change subject: switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

switch engine plugin to use system() instead of os.system to prevent screen alterations

rhbz#814413

Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Signed-off-by: Joey Boggs 
---
M vdsm_reg/engine.py
1 file changed, 5 insertions(+), 8 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/3742/1
--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm_reg/engine.py
Line 31: import subprocess
I've liked that space line, actually. please do not kill it.

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 9: rhbz#814413
Joey, thank's  for you patches.
Just a minor comment for this patch and the nexts (I hope  :) )
If you solve the bugzilla, please use the following format in your commit message:

BZ#XXXXXX - bla bla....

it will more easy to maintainer deal with such patches.

Thanks

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Igor Lvovsky

Dmitry Fleytman has posted comments on this change.

Change subject: switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Igor Lvovsky

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Hi Joey,
I want to take your patch in, but I need you rebase it on top of master.
Please, address my previous comment according to commit message.

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Igor Lvovsky

Change in vdsm[master]: BZ#814413 - switch engine plugin to use system() instead of ...

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#814413 - switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 3:

Thanks Joey
I just fix a little the commit message

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Joey Boggs

Change in vdsm[master]: BZ#814413 - switch engine plugin to use system() instead of ...

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: BZ#814413 - switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Joey Boggs

Change in vdsm[master]: BZ#814413 - switch engine plugin to use system() instead of ...

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#814413 - switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Joey Boggs

Change in vdsm[master]: BZ#814413 - switch engine plugin to use system() instead of ...

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: BZ#814413 - switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

Patch Set 4: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Joey Boggs

Change in vdsm[master]: BZ#814413 - switch engine plugin to use system() instead of ...

[Igor Lvovsky]

Igor Lvovsky has submitted this change and it was merged.

Change subject: BZ#814413 - switch engine plugin to use system() instead of os.system to prevent screen alterations
......................................................................

BZ#814413 - switch engine plugin to use system() instead of os.system to prevent screen alterations

Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Signed-off-by: Joey Boggs 
---
M vdsm_reg/engine.py.in
1 file changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, but someone else must approve
  Igor Lvovsky: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/3742
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b66f46f16703482e14ddeb8d45d9ab7e4910b04
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dmitry Fleytman 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Joey Boggs