Change in vdsm[master]: spec: Clean up the initscripts requirement

[Allon Mureinik]

Allon Mureinik has uploaded a new change for review.

Change subject: spec: Clean up the initscripts requirement
......................................................................

spec: Clean up the initscripts requirement

Centos has delivered initscripts >= 9.49.30-1.el7_2.3 since August
2nd, 2016 (see, e.g. [1]).
Given that, the TODO comment in the spec file can be addressed and
the file cleaned up a bit.

[1] http://mirror.centos.org/centos/7/updates/x86_64/Packages/

Change-Id: I0c9441c7d1ab9483780cb037f4a5567efdabaeae
Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/65055/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 9d35711..2842afa 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -220,10 +220,7 @@
 Requires: policycoreutils-python
 Requires: selinux-policy-targeted >= 3.13.1-60.el7
 Requires: systemd >= 219-11.el7
-%if ! 0%{?centos}
-# TODO drop this if when this initscripts is available on centos
 Requires: initscripts >= 9.49.30-1.el7_2.3
-%endif  #!centos
 %else
 Requires: fence-agents-all
 Requires: kernel >= 4.1.6


-- 
To view, visit https://gerrit.ovirt.org/65055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c9441c7d1ab9483780cb037f4a5567efdabaeae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt;

gerrit-hooks has posted comments on this change.

Change subject: spec: Clean up the initscripts requirement
......................................................................


Patch Set 1:

* #7::Update tracker: OK
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and
is a valid url.
* Check merged to previous::IGNORE,         Not in stable branch (['ovirt-3.6',
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9441c7d1ab9483780cb037f4a5567efdabaeae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Allon Mureinik]

Allon Mureinik has posted comments on this change.

Change subject: spec: Clean up the initscripts requirement
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9441c7d1ab9483780cb037f4a5567efdabaeae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: Clean up the initscripts requirement
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9441c7d1ab9483780cb037f4a5567efdabaeae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: spec: Clean up the initscripts requirement
......................................................................


spec: Clean up the initscripts requirement

Centos has delivered initscripts >= 9.49.30-1.el7_2.3 since August
2nd, 2016 (see, e.g. [1]).
Given that, the TODO comment in the spec file can be addressed and
the file cleaned up a bit.

[1] http://mirror.centos.org/centos/7/updates/x86_64/Packages/

Change-Id: I0c9441c7d1ab9483780cb037f4a5567efdabaeae
Signed-off-by: Allon Mureinik <amureini(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/65055
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/65055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c9441c7d1ab9483780cb037f4a5567efdabaeae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;

gerrit-hooks has posted comments on this change.

Change subject: spec: Clean up the initscripts requirement
......................................................................


Patch Set 2:

* #65055::Update tracker: OK
* #7::Update tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/65055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c9441c7d1ab9483780cb037f4a5567efdabaeae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: No