Hello Yaniv Bronhaim, Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/47600
to review the following change.
Change subject: spec: Unbreak build on rhel ......................................................................
spec: Unbreak build on rhel
centos is not defined, breaking the build on a rhel machine.
Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99 Backport-To: 3.6 Backport-To: 3.5 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/47583 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/47600/1
diff --git a/vdsm.spec.in b/vdsm.spec.in index e05be56..95702c6 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -176,7 +176,7 @@ Requires: sanlock >= 2.8, sanlock-python
%if 0%{?rhel} -%if 0%{centos} +%if 0%{?centos} Requires: device-mapper-multipath >= 0.4.9-68 %else Requires: device-mapper-multipath >= 0.4.9-77.el7_1.2
automation@ovirt.org has posted comments on this change.
Change subject: spec: Unbreak build on rhel ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: spec: Unbreak build on rhel ......................................................................
Patch Set 1: Verified+1
Verified on master.
Nir Soffer has posted comments on this change.
Change subject: spec: Unbreak build on rhel ......................................................................
Patch Set 1:
We don't have a bug, but I don't think we need one.
Francesco Romani has posted comments on this change.
Change subject: spec: Unbreak build on rhel ......................................................................
Patch Set 1: Code-Review+2
Francesco Romani has submitted this change and it was merged.
Change subject: spec: Unbreak build on rhel ......................................................................
spec: Unbreak build on rhel
centos is not defined, breaking the build on a rhel machine.
Change-Id: Ic9649f224648aec7c6bf78fef24ec121ebae5e99 Backport-To: 3.6 Backport-To: 3.5 Signed-off-by: Nir Soffer nsoffer@redhat.com Reviewed-on: https://gerrit.ovirt.org/47583 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani fromani@redhat.com Reviewed-by: Yaniv Bronhaim ybronhei@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com Reviewed-on: https://gerrit.ovirt.org/47600 --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Nir Soffer: Verified Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved
automation@ovirt.org has posted comments on this change.
Change subject: spec: Unbreak build on rhel ......................................................................
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.
vdsm-patches@lists.fedorahosted.org