3:37 a.m.
Piotr Kliczewski has uploaded a new change for review.
Change subject: logging: remove log messages which give little or no value
......................................................................
logging: remove log messages which give little or no value
Some of the messages logged during jsonrpc request processing give no or
little value when diagnosing the issues but are logged quite often.
This patch removes those messages.
Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1239062
---
M lib/yajsonrpc/__init__.py
M lib/yajsonrpc/stompReactor.py
2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/43262/1
diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py
index 5b476a2..53b4e2f 100644
--- a/lib/yajsonrpc/__init__.py
+++ b/lib/yajsonrpc/__init__.py
@@ -527,7 +527,6 @@
@traceback(on=log.name)
def serve_requests(self):
while True:
- self.log.debug("Waiting for request")
obj = self._workQueue.get()
if obj is None:
break
diff --git a/lib/yajsonrpc/stompReactor.py b/lib/yajsonrpc/stompReactor.py
index 78b274b..3f003c6 100644
--- a/lib/yajsonrpc/stompReactor.py
+++ b/lib/yajsonrpc/stompReactor.py
@@ -95,7 +95,6 @@
self._messageHandler(self, frame.body)
def handle_frame(self, dispatcher, frame):
- self.log.debug("Handling message %s", frame)
try:
self._commands[frame.command](dispatcher, frame)
except KeyError:
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
3:37 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
......................................................................
Patch Set 1:
* Update tracker::#1239062::OK
* Check Bug-Url::OK
* Check Public Bug::#1239062::OK, public bug
* Check Product::#1239062::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1239062::OK, correct target release 3.5.5
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3:38 a.m.
Piotr Kliczewski has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
......................................................................
Patch Set 1: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
5:03 a.m.
Dima Kuznetsov has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
7:04 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
......................................................................
Patch Set 2:
* Update tracker::#1243710::OK
* Check Bug-Url::OK
* Check Public Bug::#1243710::OK, public bug
* Check Product::#1243710::OK, Correct product Red Hat Enterprise Virtualization Manager
* Check TR::#1243710::OK, correct target release 3.5.5
* warn_if_not_merged_to_previous_branch: OK
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
9:57 a.m.
Yaniv Bronhaim has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
12:29 a.m.
Oved Ourfali has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
......................................................................
Patch Set 2:
can we make sure the master patch is merged, and also merge this one?
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
4:11 a.m.
Francesco Romani has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
4:12 a.m.
Francesco Romani has submitted this change and it was merged.
Change subject: logging: remove log messages which give little or no value
......................................................................
logging: remove log messages which give little or no value
Some of the messages logged during jsonrpc request processing give no or
little value when diagnosing the issues but are logged quite often.
This patch removes those messages.
Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Bug-Url: https://bugzilla.redhat.com/1243710
Reviewed-on: https://gerrit.ovirt.org/43262
Continuous-Integration: Jenkins CI
Reviewed-by: Dima Kuznetsov <dmitrykuzn(a)gmail.com>
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
Reviewed-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/yajsonrpc/__init__.py
M lib/yajsonrpc/stompReactor.py
2 files changed, 0 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Dima Kuznetsov: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
4:12 a.m.
automation(a)ovirt.org has posted comments on this change.
Change subject: logging: remove log messages which give little or no value
......................................................................
Patch Set 3:
* Update tracker::#1243710::OK
* Set MODIFIED::bug 1243710::::#1243710::::IGNORE, not oVirt prod but Red Hat Enterprise
Virtualization Manager
--
To view, visit https://gerrit.ovirt.org/43262
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c6648f39b24adb1a5950c80a3883de0182b3b4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dmitrykuzn(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
3182
days inactive
3241
days old
vdsm-patches@lists.fedorahosted.org
9 comments
6 participants
participants (6)
-
automation＠ovirt.org -
dkuznets＠redhat.com -
fromani＠redhat.com -
Oved Ourfali -
Piotr Kliczewski -
ybronhei＠redhat.com