Change in vdsm[master]: vdsm-reg: change registration servlet name

[Roy Golan]

Roy Golan has uploaded a new change for review.

Change subject: vdsm-reg: change registration servlet name
......................................................................

vdsm-reg: change registration servlet name

Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
---
M vdsm_reg/vdsm-reg.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/10/310/1
--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;

[Roy Golan]

Roy Golan has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 1:

I'm just sending a patch to change that to /register so the link would be
http://ovirt:8080/register

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 3: No score

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm-reg: change registration servlet name
......................................................................


vdsm-reg: change registration servlet name

Note that this change prohibits registration of Vdsm to RHEV-M-3.0.
It depends on ovirt-engine change I4f36a302adbafdc5f9d0bb219896c794cbad31dd
BZ# 752464.

Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
---
M vdsm_reg/vdsm-reg.conf.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 5: Verified; Looks good to me, approved

I'm taking this in, under the understanding that a compatible name change in
ovirt-engine is imminent.

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 3: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 2:

Roy, 

 Can you please update the commit message and include the BZ# 752464? If you prefer I can
do it.

Thanks
Douglas

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 2: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 2:

Moved to POST BZ753879 and BZ753571

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 1: I would prefer that you didn't submit this

The only problem I see with this kind of changes is, that new ovirt-nodes would not be
able to register to old RHEV-M (v3.0). But I'm happy with that. If we need a more
complex compatibility matrix, we'd have to rethink these two patches.

Roy/Douglas, please update the commit message to mention the relevant bug being fixed by
this (752464 ?), and move it to POST.

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 1: Verified; Looks good to me, but someone else must approve

Applied the patches available: http://gerrit.ovirt.org/#change,318 and the url provided by
Roy is working, no more 404 error.

from:
/usr/local/jboss/server/default/deploy/engine.ear/enginemanagerweb.war/WEB-INF/web.xml

<snip>
<servlet-mapping>
          <servlet-name>RegisterServlet</servlet-name>
           <url-pattern>/register</url-pattern>
</servlet-mapping>
</snip>

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 1:

Hello Roy,

Thanks for the feedback, with the changes provided here:
http://gerrit.ovirt.org/#change,318 this patch make sense. Before I push
'verified' let me test it.

Cheers
Douglas

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Hello Roy,

Looking the file:
frontend/wars/rmw-war/src/main/webapp/WEB-INF/web.xml

It says:

<servlet-mapping>
   <servlet-name>RegisterServlet</servlet-name>
   <url-pattern>/RegisterServlet/*</url-pattern>
</servlet-mapping>

It seems all commands should use RegisterServlet. Can you please review your patch and/or
this source file?

Thanks!
Douglas

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 1:

I know that the URL I have used was generated because a wrong sed command that will be
fixed but if I understood correctly the BZ752464 the registration url should be:

http://<IP>:<PORT>/EngineManagerWeb/RegisterServlet/register

instead of 
http://<IP>:<PORT>/EngineManagerWeb/register

anyway, I am going to check.

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 1:

During my tests I have used
http://<IP>:8080/ENGINEanagerWeb/RegisterServlet/register. 

accordingly with:
https://bugzilla.redhat.com/show_bug.cgi?id=752464#c6

Going to verify this new url provided.

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg: change registration servlet name
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/310
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I743bfc8258a7cf8fd032cde13aadd2827ed9ea29
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;