Change in vdsm[master]: trivial: Use os.uname to get kernel version insteaf of readi...

Mark Wu has uploaded a new change for review.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

trivial: Use os.uname to get kernel version insteaf of reading proc files

Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Signed-off-by: Mark Wu 
---
M vdsm/caps.py
1 file changed, 6 insertions(+), 11 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/12874/1

diff --git a/vdsm/caps.py b/vdsm/caps.py
index 38e47be..613de0c 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -312,18 +312,13 @@
 def _getKeyPackages():
     def kernelDict():
         try:
-            with open('/proc/sys/kernel/osrelease', "r") as f:
-                ver, rel = f.read().strip().split('-', 1)
+            ret = os.uname()
+            ver, rel = ret[2].split('-', 1)
+            t = time.mktime(time.strptime(' '.join(ret[3].split()[2:]),
+                                          "%a %b %d %H:%M:%S %Z %Y"))
         except:
-            logging.error('kernel release not found', exc_info=True)
-            ver, rel = '0', '0'
-        try:
-            t = file('/proc/sys/kernel/version').read().split()[2:]
-            del t[4]  # Delete timezone
-            t = time.mktime(time.strptime(' '.join(t)))
-        except:
-            logging.error('kernel build time not found', exc_info=True)
-            t = '0'
+            ver, rel, t = '0', '0', '0'
+            logging.error('kernel version not found', exc_info=True)
         return dict(version=ver, release=rel, buildtime=t)

pkgs = {'kernel': kernelDict()}

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1523/ (1/2)

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1486/ (2/2)

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1523/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1486/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 1: (2 inline comments)

thanks! but few comments.

....................................................
File vdsm/caps.py
Line 311: 
Line 312: def _getKeyPackages():
Line 313:     def kernelDict():
Line 314:         try:
Line 315:             ret = os.uname()
calling os.uname() is obviously cleaner, but could you maintain the same level of robustness of the original code?

I mean that formerly, a kernel without a date, would still report its version. so please keep the separation of the try-except blocks.
Line 316:             ver, rel = ret[2].split('-', 1)
Line 317:             t = time.mktime(time.strptime(' '.join(ret[3].split()[2:]),
Line 318:                                           "%a %b %d %H:%M:%S %Z %Y"))
Line 319:         except:

Line 314:         try:
Line 315:             ret = os.uname()
Line 316:             ver, rel = ret[2].split('-', 1)
Line 317:             t = time.mktime(time.strptime(' '.join(ret[3].split()[2:]),
Line 318:                                           "%a %b %d %H:%M:%S %Z %Y"))
I do not recall the details, but there has been a libc issue that forced us to drop the timezone (in case the kernel was built in a timezone that strptime() does not recognize, or something like that).
Line 319:         except:
Line 320:             ver, rel, t = '0', '0', '0'
Line 321:             logging.error('kernel version not found', exc_info=True)
Line 322:         return dict(version=ver, release=rel, buildtime=t)

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 1: (2 inline comments)

....................................................
File vdsm/caps.py
Line 311: 
Line 312: def _getKeyPackages():
Line 313:     def kernelDict():
Line 314:         try:
Line 315:             ret = os.uname()
The build date is auto generated by kernel build script. So i think it's safe to use on try-except block. Is this reason acceptable?
Line 316:             ver, rel = ret[2].split('-', 1)
Line 317:             t = time.mktime(time.strptime(' '.join(ret[3].split()[2:]),
Line 318:                                           "%a %b %d %H:%M:%S %Z %Y"))
Line 319:         except:

Line 314:         try:
Line 315:             ret = os.uname()
Line 316:             ver, rel = ret[2].split('-', 1)
Line 317:             t = time.mktime(time.strptime(' '.join(ret[3].split()[2:]),
Line 318:                                           "%a %b %d %H:%M:%S %Z %Y"))
Done
Line 319:         except:
Line 320:             ver, rel, t = '0', '0', '0'
Line 321:             logging.error('kernel version not found', exc_info=True)
Line 322:         return dict(version=ver, release=rel, buildtime=t)

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1494/ (2/2)

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1531/ (1/2)

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 1: (1 inline comment)

....................................................
File vdsm/caps.py
Line 311: 
Line 312: def _getKeyPackages():
Line 313:     def kernelDict():
Line 314:         try:
Line 315:             ret = os.uname()
Please see https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts...
Line 316:             ver, rel = ret[2].split('-', 1)
Line 317:             t = time.mktime(time.strptime(' '.join(ret[3].split()[2:]),
Line 318:                                           "%a %b %d %H:%M:%S %Z %Y"))
Line 319:         except:

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1531/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1494/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/caps.py
Line 313:     def kernelDict():
Line 314:         try:
Line 315:             ret = os.uname()
Line 316:             ver, rel = ret[2].split('-', 1)
Line 317:             t = ret[3].split()[2:]
would you explain why you insist to join the except blocks?

all I have in favor of keeping the current split is "tradition" and a vague memory, so I am open for convincing.
Line 318:             del t[4]  # Delete timezone
Line 319:             t = time.mktime(time.strptime(' '.join(t)))
Line 320:         except:
Line 321:             ver, rel, t = '0', '0', '0'

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 2: (1 inline comment)

It seems that it's a good practice to leave a cover message to highlight the change from last version and something for reviewers to note. The comments inline are easily ignored.

....................................................
File vdsm/caps.py
Line 313:     def kernelDict():
Line 314:         try:
Line 315:             ret = os.uname()
Line 316:             ver, rel = ret[2].split('-', 1)
Line 317:             t = ret[3].split()[2:]
It's explained in the comments in patch set v1:

The build date is auto generated by kernel build script. So i think it's safe to use on try-except block. Is this reason acceptable?
Reply ...Reply 'Done'
    			
Please see https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts...
Line 318:             del t[4]  # Delete timezone
Line 319:             t = time.mktime(time.strptime(' '.join(t)))
Line 320:         except:
Line 321:             ver, rel, t = '0', '0', '0'

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 2:

@Dan, any comments on this patch? Thanks!

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 2:

I usually take great care to see read all responses to my comments. I do not know how I've missed yours, and I apologize.

However, as I've said, I have a vague memory of someone using a non-default kernel and exploding on this triviality.

This might have been before there was any try-except protection, and there's nothing really to be afraid of now - but I do not quite understand the eagerness for a change per se.

I prefer that you keep the separation, but I am not adamant about it.

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1819/ (1/2)

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1768/ (2/2)

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: oVirt Jenkins CI Server

Mark Wu has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1768/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1819/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

Zhou Zheng Sheng has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

Patch Set 3: Looks good to me, approved

sorry for nagging, Mark...

Thanks!

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: trivial: Use os.uname to get kernel version insteaf of reading proc files
......................................................................

trivial: Use os.uname to get kernel version insteaf of reading proc files

Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Signed-off-by: Mark Wu 
---
M vdsm/caps.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Mark Wu: Verified
  Dan Kenigsberg: Looks good to me, approved
  Zhou Zheng Sheng: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/12874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bcb4326d6ce4a41486352e11683c83879b61887
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Douglas Schilling Landgraf 
Gerrit-Reviewer: Mark Wu 
Gerrit-Reviewer: Zhou Zheng Sheng 
Gerrit-Reviewer: oVirt Jenkins CI Server