Dan Kenigsberg has uploaded a new change for review.
Change subject: fuser.fuser() requires `sudo fuser` ......................................................................
fuser.fuser() requires `sudo fuser`
Fail politely if the testing user does not have it.
Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M tests/fuserTests.py 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/13778/1
diff --git a/tests/fuserTests.py b/tests/fuserTests.py index 7473dde..c5c34a4 100644 --- a/tests/fuserTests.py +++ b/tests/fuserTests.py @@ -22,10 +22,13 @@ from storage import fuser
from testrunner import VdsmTestCase +from testValidation import checkSudo
class TestFuser(VdsmTestCase):
def testSelfExe(self): pid = os.getpid() - self.assertTrue(pid in fuser.fuser('/proc/%s/exe' % pid)) + exeFile = '/proc/%s/exe' % pid + checkSudo(['fuser', exeFile]) + self.assertTrue(pid in fuser.fuser(exeFile))
-- To view, visit http://gerrit.ovirt.org/13778 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fuser.fuser() requires `sudo fuser` ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1938/ (1/2)
-- To view, visit http://gerrit.ovirt.org/13778 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fuser.fuser() requires `sudo fuser` ......................................................................
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1887/ (2/2)
-- To view, visit http://gerrit.ovirt.org/13778 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fuser.fuser() requires `sudo fuser` ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/1887/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/1938/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/13778 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yeela Kaplan has posted comments on this change.
Change subject: fuser.fuser() requires `sudo fuser` ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/13778 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Yeela Kaplan has posted comments on this change.
Change subject: fuser.fuser() requires `sudo fuser` ......................................................................
Patch Set 1: Verified
-- To view, visit http://gerrit.ovirt.org/13778 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Saggi Mizrahi has posted comments on this change.
Change subject: fuser.fuser() requires `sudo fuser` ......................................................................
Patch Set 1: Do not submit
I already sent a proper fix http://gerrit.ovirt.org/#/c/13779/
-- To view, visit http://gerrit.ovirt.org/13778 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has abandoned this change.
Change subject: fuser.fuser() requires `sudo fuser` ......................................................................
Patch Set 1: Abandoned
Saggi's take is indeed better.
-- To view, visit http://gerrit.ovirt.org/13778 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I8a58344cc679ffe30ad0fd345340c212f20fd9e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com Gerrit-Reviewer: Yeela Kaplan ykaplan@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org