Change in vdsm[master]: [WIP] Implement storage server connection monitoring

Saggi Mizrahi has uploaded a new change for review.

Change subject: [WIP] Implement storage server connection monitoring
......................................................................

[WIP] Implement storage server connection monitoring

Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380
---
M vdsm.spec.in
M vdsm/storage/Makefile.am
M vdsm/storage/hsm.py
M vdsm/storage/storageServer.py
A vdsm/storage/sync.py
5 files changed, 304 insertions(+), 15 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/1694/1
--
To view, visit http://gerrit.ovirt.org/1694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi

Change in vdsm[master]: Implement storage server connection monitoring

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Implement storage server connection monitoring
......................................................................

Patch Set 4: (1 inline comment)

Partially reviewed, it's too big

....................................................
Commit Message
Line 11: connectino once there are no aliases referencing it.
s/connectino/connection

--
To view, visit http://gerrit.ovirt.org/1694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Implement storage server connection monitoring

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Implement storage server connection monitoring
......................................................................

Patch Set 4: (4 inline comments)

....................................................
File vdsm/storage/hsm.py
Line 293:             self._connectionMonitor.restorePersistedConnections()
restorePersistedConnections doesn't exists

Line 294:             self._connectionMonitor.startMonitoring()
In the next patch you're moving this to line 279, can you do it now?

....................................................
File vdsm/storage/storageServer.py
Line 508:                     with self._activeOpsLock:
This method looks quite long and very much indented. Any chance to move something out to an other method? (Eg: this "with" block).

....................................................
File vdsm/storage/sync.py
Line 22:     def result(self):
Does this mean that if we ask for the result while it's not completed yet we'll simply get a (None, None)? This means that it can be used only with wait() (and it also assumes that the user doesn't do mistakes). Don't you think it would be better to raise an exception?

--
To view, visit http://gerrit.ovirt.org/1694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Implement storage server connection monitoring

[Federico Simoncelli]

Federico Simoncelli has posted comments on this change.

Change subject: Implement storage server connection monitoring
......................................................................

Patch Set 5: I would prefer that you didn't submit this

I had several interesting comments in patch set 4.

--
To view, visit http://gerrit.ovirt.org/1694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Implement storage server connection monitoring

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Implement storage server connection monitoring
......................................................................

Patch Set 12: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi

Change in vdsm[master]: Implement storage server connection monitoring

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Implement storage server connection monitoring
......................................................................

Implement storage server connection monitoring

This is the actual connection monitoring. Takes aliased connection
Information and makes sure everything is connected. It will disconnect a
connectino once there are no aliases referencing it.

Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380
---
M vdsm.spec.in
M vdsm/storage/Makefile.am
M vdsm/storage/hsm.py
M vdsm/storage/storageServer.py
A vdsm/storage/sync.py
5 files changed, 221 insertions(+), 2 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi