Antoni Segura Puimedon has uploaded a new change for review.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
netwiring: [1/4] Extend vmInterfaceDevice API def
This patch extends the definitions of vmInterfaceDevice in order to allow vmHotplugNic and vmCreate to set a vnic link status as well as set portMirroring for it.
Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/9599/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json index 843cbc7..2c02804 100644 --- a/vdsm_api/vdsmapi-schema.json +++ b/vdsm_api/vdsmapi-schema.json @@ -1980,6 +1980,11 @@ # # @specParams: #optional Additional device parameters # +# @linkActive: #optional Whether the VM network card has its link active (up) +# or not (down). If omitted, the link will be active +# @portMirroring: #optional If present, indicates the traffic of which networks +# should be mirrored to the interface. +# # Since: 4.10.0 ## {'type': 'VmInterfaceDevice', @@ -1987,7 +1992,8 @@ 'nicModel': 'VmInterfaceDeviceModel', 'macAddr': 'str', 'network': 'str', '*bootOrder': 'uint', 'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID', - '*specParams': 'VmInterfaceDeviceSpecParams'}} + '*specParams': 'VmInterfaceDeviceSpecParams', '*linkActive': 'bool', + '*portMirroring': ['str']}}
## # @VmVideoDeviceType:
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com
Mark Wu has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
Patch Set 2: No score
Back to 0 while we discuss the linkState property.
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
Patch Set 2: No score
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Adam Litke has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
Patch Set 2: Looks good to me, approved
Agreement was reached after discussion on list. Approving.
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
Patch Set 2: Verified
pushing updateDev preparation patches - their +2s confuse me.
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def ......................................................................
netwiring: [1/4] Extend vmInterfaceDevice API def
This patch extends the definitions of vmInterfaceDevice in order to allow vmHotplugNic and vmCreate to set a vnic link status as well as set portMirroring for it.
Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Signed-off-by: Antoni S. Puimedon asegurap@redhat.com --- M vdsm_api/vdsmapi-schema.json 1 file changed, 19 insertions(+), 12 deletions(-)
Approvals: Adam Litke: Looks good to me, approved Mark Wu: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/9599 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I4ef8ad6963682a38d5f65d718e5b2a465ef3af82 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Alona Kaplan alkaplan@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegurap@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Livnat Peer lpeer@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org