Change in vdsm[master]: fix: sockets/cores retrieval from cpu topology

Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/9386

to review the following change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

fix: sockets/cores retrieval from cpu topology

topology tag in capabilities from libvirt is missing in some
environment.  This fix assumes default sockets and cores as 1 when
topology tag missing

Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Signed-off-by: Bala.FA 
---
M vdsm/caps.py
1 file changed, 8 insertions(+), 4 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/9386/1

diff --git a/vdsm/caps.py b/vdsm/caps.py
index fdb06b1..c77a05c 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -111,12 +111,16 @@
         caps = minidom.parseString(c.getCapabilities())
     host = caps.getElementsByTagName('host')[0]
     cpu = host.getElementsByTagName('cpu')[0]
+    topology = cpu.getElementsByTagName('topology')
+    sockets = 1
+    cores = 1
+    if topology:
+        sockets = int(topology[0].getAttribute('sockets'))
+        cores = int(topology[0].getAttribute('cores'))
     cells = host.getElementsByTagName('cells')[0]
     topology = {'cells': int(cells.getAttribute('num')),
-                'sockets': int(cpu.getElementsByTagName('topology')[0].
-                                                      getAttribute('sockets')),
-                'cores': int(cpu.getElementsByTagName('topology')[0].
-                                                        getAttribute('cores')),
+                'sockets': sockets,
+                'cores': cores,
                 'threads': cells.getElementsByTagName('cpu').length}
     return topology

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/86/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/120/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Bala.FA has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1: Fails

Build Failed

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/86/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/120/ : FAILURE

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1: I would prefer that you didn't submit this

I don't think we need keep the default.
This is a real bug in libvirt and we don't need workaround it.

https://bugzilla.redhat.com/show_bug.cgi?id=876475

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/caps.py
Line 115:     sockets = 1
Line 116:     cores = 1
Line 117:     if topology:
Line 118:         sockets = int(topology[0].getAttribute('sockets'))
Line 119:         cores = int(topology[0].getAttribute('cores'))
please add an "else" clause, with a proper setting og sockets/core. You can take the code from what we had before commit 90b3392ccc88. reporting "1 core" is a quite wrong.

Also add a comment linking to the libvirt bug that cause this.
Line 120:     cells = host.getElementsByTagName('cells')[0]
Line 121:     topology = {'cells': int(cells.getAttribute('num')),
Line 122:                 'sockets': sockets,
Line 123:                 'cores': cores,

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir

Amador Pahim has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1: I would prefer that you didn't submit this

Already fixed in libvirt. It doesn't seem necessary.

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir

Bala.FA has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1:

After upgrading libvirt to 0.9.10-21.el6_3.6, things are working fine.  Can I send a patch by setting this dependency than current 0.9.10-21.el6_3.5?  However libvirt-0.9.10-21.el6_3.6 is not available in RHEL 6.3 yet.

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix: sockets/cores retrieval from cpu topology
......................................................................

Patch Set 1:

Bala, yes, please send the proper libvirt requirement. But give yourself a -1 until the relevant version is available to the public in el6.

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/148/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/114/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/114/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/148/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

Bala.FA has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2: I would prefer that you didn't submit this

As libvirt version 0.9.10-21.el6_3.6 is not available publicly in RHEL, I mark it as -1 till then

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

Bala.FA has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2: No score

Removing -1 as libvirt-0.9.10-21.el6_3.6 is available in RHEL6 RHN and CentOS 6 updates

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

Bala.FA has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

Amador Pahim has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2: Looks good to me, approved

The exact libvirt bug is actually https://bugzilla.redhat.com/868972 but we should not block on that fact.

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 2: I would prefer that you didn't submit this

however, we do block on a needed rebase.

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/323/ (1/2)

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 3:

Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/289/ (2/2)

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 3:

Build Successful

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/289/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/323/ : SUCCESS

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

Amador Pahim has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

Patch Set 3: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server

Change in vdsm[master]: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL
......................................................................

set libvirt dependency version to 0.9.10-21.el6_3.6 in RHEL

When vdsm runs on RHEL based VMs, in some environment it fails to
start due to missing cpu topology information from libvirt.  This
issue is tracked at https://bugzilla.redhat.com/show_bug.cgi?id=868972
and fixed in libvirt version 0.9.10-21.el6_3.6.

Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Signed-off-by: Bala.FA 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Amador Pahim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/9386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I343db03f9cf6eefc28f993d269c6c082e7695af5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA 
Gerrit-Reviewer: Amador Pahim 
Gerrit-Reviewer: Ayal Baron 
Gerrit-Reviewer: Bala.FA 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Igor Lvovsky 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Timothy Asir 
Gerrit-Reviewer: oVirt Jenkins CI Server