Change in vdsm[master]: xmlrpc: Use correct base class for parsing request

[Nir Soffer]

Nir Soffer has uploaded a new change for review.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

xmlrpc: Use correct base class for parsing request

Previously we always used SecureXMLRPCServer.parse_request, even when
using SimpleXMLRPCServer. That happened to work since both inherit
parse_request from BaseHTTPServer. This patch use the correct base
class, so if one of them will override parse_request, we use the correct
method.

Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f
Signed-off-by: Nir Soffer 
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/24289/1

diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index b71dae5..7308c5c 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -109,8 +109,7 @@
                 return basehandler.setup(self)

def parse_request(self):
-                r = (SecureXMLRPCServer.SecureXMLRPCRequestHandler.
-                     parse_request(self))
+                r = basehandler.parse_request(self)
                 threadLocal.flowID = self.headers.get(HTTP_HEADER_FLOWID)
                 return r

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

Patch Set 1:

Build Successful

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6284/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7174/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7063/ : SUCCESS

Antoni Segura Puimedon has posted comments on this change.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

Patch Set 1: Code-Review+1

Good catch

Liron Ar has posted comments on this change.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

Patch Set 1: Code-Review+1

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

Patch Set 1: Verified+1

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

Patch Set 1: Code-Review+2

Quite an ancient issue (commit ba607427).

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

Patch Set 1: Code-Review+1

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: xmlrpc: Use correct base class for parsing request
......................................................................

xmlrpc: Use correct base class for parsing request

Previously we always used SecureXMLRPCServer.parse_request, even when
using SimpleXMLRPCServer. That happened to work since both inherit
parse_request from BaseHTTPServer. This patch use the correct base
class, so if one of them will override parse_request, we use the correct
method.

Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f
Signed-off-by: Nir Soffer 
Reviewed-on: http://gerrit.ovirt.org/24289
Reviewed-by: Antoni Segura Puimedon 
Reviewed-by: Liron Ar 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Douglas Schilling Landgraf 
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Liron Ar: Looks good to me, but someone else must approve