Eduardo has uploaded a new change for review.
Change subject: Remove checkImage ......................................................................
Remove checkImage
Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e --- M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/sp.py M vdsm_cli/vdsClient.py 4 files changed, 0 insertions(+), 77 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/426/1 -- To view, visit http://gerrit.ovirt.org/426 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Remove checkImage ......................................................................
Patch Set 1: Do not submit
Please try and do it on top of my WIP
-- To view, visit http://gerrit.ovirt.org/426 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove checkImage ......................................................................
Patch Set 1: I would prefer that you didn't submit this
Saggi, your WIP is not to be committed in the coming days, we should not be waiting with obvious cleanups like this.
Edu, please have a fatter commit message.
-- To view, visit http://gerrit.ovirt.org/426 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Saggi Mizrahi has posted comments on this change.
Change subject: Remove checkImage ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
Go ahead and push it. I'll rebase.
-- To view, visit http://gerrit.ovirt.org/426 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Remove checkImage ......................................................................
Patch Set 3: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/426 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove checkImage ......................................................................
Remove checkImage
This API function is unused and is based on buggy functions with outdated semantics.
Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e --- M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/sp.py M vdsm_cli/vdsClient.py 4 files changed, 0 insertions(+), 77 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/426 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I691cbc8e92b048a0c803851596f9579ded2b1e4e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com
vdsm-patches@lists.fedorahosted.org