Change in vdsm[master]: Remove redundant 'explicitBonding' parameter from setupNetwo...

[Igor Lvovsky]

Igor Lvovsky has uploaded a new change for review.

Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks
......................................................................

Remove redundant 'explicitBonding' parameter from setupNetworks

Change-Id: Id8cd878109ab5fe9d082412f6d05e1c964823779
Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
---
M vdsm/configNetwork.py
1 file changed, 2 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/5840/1
--
To view, visit http://gerrit.ovirt.org/5840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8cd878109ab5fe9d082412f6d05e1c964823779
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks
......................................................................


Remove redundant 'explicitBonding' parameter from setupNetworks

Change-Id: Id8cd878109ab5fe9d082412f6d05e1c964823779
Signed-off-by: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
---
M vdsm/configNetwork.py
1 file changed, 8 insertions(+), 26 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id8cd878109ab5fe9d082412f6d05e1c964823779
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks
......................................................................


Patch Set 3: Verified; Looks good to me, approved

pushing, with a fix of tabs to spaces.

--
To view, visit http://gerrit.ovirt.org/5840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd878109ab5fe9d082412f6d05e1c964823779
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/5840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd878109ab5fe9d082412f6d05e1c964823779
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

yay. anything that makes this spaghetti cleaner is welcome. but see minor comment.

....................................................
File vdsm/configNetwork.py
Line 1058
I think that the note until this "However", should stay. it has useful
information, at least for me.

--
To view, visit http://gerrit.ovirt.org/5840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd878109ab5fe9d082412f6d05e1c964823779
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/5840
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd878109ab5fe9d082412f6d05e1c964823779
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;