10:15 a.m.
Francesco Romani has uploaded a new change for review.
Change subject: tests: update libvirt fake object
......................................................................
tests: update libvirt fake object
commit eb2ef555345a32a4f0153ac0341b4c422cdacf8c
requires the 'close' method to be present.
This patch updates the tests to let 'make check' run cleanly again.
Change-Id: I1bb271d90ca8d20f83ab0af38e96598991115ad2
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/libvirtconnectionTests.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/27323/1
diff --git a/tests/libvirtconnectionTests.py b/tests/libvirtconnectionTests.py
index 32a6fd4..1ac60a0 100644
--- a/tests/libvirtconnectionTests.py
+++ b/tests/libvirtconnectionTests.py
@@ -73,6 +73,9 @@
else:
return ''
+ def close(self):
+ pass
+
class virDomain(object):
pass
--
To view, visit http://gerrit.ovirt.org/27323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bb271d90ca8d20f83ab0af38e96598991115ad2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
3:52 a.m.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: update libvirt fake object
......................................................................
tests: update libvirt fake object
commit eb2ef555345a32a4f0153ac0341b4c422cdacf8c
requires the 'close' method to be present.
This patch updates the tests to let 'make check' run cleanly again.
Change-Id: I1bb271d90ca8d20f83ab0af38e96598991115ad2
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/27323
Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/libvirtconnectionTests.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit http://gerrit.ovirt.org/27323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bb271d90ca8d20f83ab0af38e96598991115ad2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
1:22 p.m.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: tests: update libvirt fake object
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb271d90ca8d20f83ab0af38e96598991115ad2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
10:16 a.m.
Francesco Romani has posted comments on this change.
Change subject: tests: update libvirt fake object
......................................................................
Patch Set 1: Verified+1
fixes locally.
--
To view, visit http://gerrit.ovirt.org/27323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb271d90ca8d20f83ab0af38e96598991115ad2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No
10:19 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: update libvirt fake object
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8510/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/7720/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/8636/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/27323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb271d90ca8d20f83ab0af38e96598991115ad2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3:52 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: tests: update libvirt fake object
......................................................................
Patch Set 1: Code-Review+2
Careless verification :-(
--
To view, visit http://gerrit.ovirt.org/27323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bb271d90ca8d20f83ab0af38e96598991115ad2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
3654
days inactive
3655
days old
vdsm-patches@lists.fedorahosted.org
5 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Douglas Schilling Landgraf -
fromani＠redhat.com -
Jenkins CI RO