From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: fix typo in __init__
......................................................................
vm: fix typo in __init__
In commit 293c488e a typo sneaked in Vm.__init__.
Apparently, it is harmless:
$ cat tx.py
class Test(object):
def __init__(self, params):
self.conf = {'pid': '0', '_blockJobs': {},
'clientIp': ''}
self.conf.update(params)
if 'smp' not in self .conf: # <== note the space!
self.conf['smp'] = '1'
def __repr__(self):
return repr(self.conf)
print Test({})
print Test({'smp': 8})
$ python tx.py
{'_blockJobs': {}, 'clientIp': '', 'pid': '0',
'smp': '1'}
{'_blockJobs': {}, 'clientIp': '', 'pid': '0',
'smp': 8}
This patches fixes it anyway.
Change-Id: Ifa7cd384f983a9a97feea260b8c769bfbb32a306
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit
https://gerrit.ovirt.org/76323
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa7cd384f983a9a97feea260b8c769bfbb32a306
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>