Change in vdsm[master]: Adding call to svdsm.ping from vdsm ping verb

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Adding call to svdsm.ping from vdsm ping verb
......................................................................

Adding call to svdsm.ping from vdsm ping verb

In additional to adding supervdsm ping call, this also allows calling to ping
verb from vdsClient

Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M client/vdsClient.py
M vdsm/API.py
2 files changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/18329/1

diff --git a/client/vdsClient.py b/client/vdsClient.py
index c52256a..38a09e8 100644
--- a/client/vdsClient.py
+++ b/client/vdsClient.py
@@ -1744,6 +1744,10 @@
 
         return status['status']['code'],
status['status']['message']
 
+    def do_ping(self, args):
+        return self.ExecAndExit(self.s.ping())
+
+
 if __name__ == '__main__':
     if _glusterEnabled:
         serv = ge.GlusterService()
@@ -2489,6 +2493,11 @@
                 '<vmId> <spUUID> <sdUUID> <imgUUID>
<volUUID> <newSize>',
                 'Extends the virtual size of a disk'
             )),
+        'ping': (
+            serv.do_ping, (
+                '',
+                'Check connectivity with vdsm and supervdsm'
+            )),
     }
     if _glusterEnabled:
         commands.update(ge.getGlusterCmdDict(serv))
diff --git a/vdsm/API.py b/vdsm/API.py
index 37bb908..58d6815 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1152,6 +1152,12 @@
 
     def ping(self):
         "Ping the server. Useful for tests"
+        try:
+            supervdsm.getProxy().ping()
+        except:
+            return {'status':
+                    {'code': 1, 'message': "Couldn't ping
supervdsm"}}
+
         return {'status': doneCode}
 
     def getCapabilities(self):


-- 
To view, visit http://gerrit.ovirt.org/18329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding call to svdsm.ping from vdsm ping verb
......................................................................


Patch Set 1: Code-Review-1

Build Unstable 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4038/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3143/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3950/ : UNSTABLE

-- 
To view, visit http://gerrit.ovirt.org/18329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding call to svdsm.ping from vdsm ping verb
......................................................................


Patch Set 1: -Code-Review

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4038/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3143/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3953/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/18329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Saggi Mizrahi has posted comments on this change.

Change subject: Adding call to svdsm.ping from vdsm ping verb
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
File vdsm/API.py
Line 1152: 
Line 1153:     def ping(self):
Line 1154:         "Ping the server. Useful for tests"
Line 1155:         try:
Line 1156:             supervdsm.getProxy().ping()
Either log or return the of the original exception.
It's the thing we really want to know in those cases
Line 1157:         except:
Line 1158:             return {'status':
Line 1159:                     {'code': 1, 'message': "Couldn't
ping supervdsm"}}
Line 1160: 


-- 
To view, visit http://gerrit.ovirt.org/18329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Adding call to svdsm.ping from vdsm ping verb
......................................................................


Patch Set 2: Code-Review-1

Build Unstable 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4040/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3145/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3955/ : UNSTABLE

-- 
To view, visit http://gerrit.ovirt.org/18329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Adding call to svdsm.ping from vdsm ping verb
......................................................................


Patch Set 2: Code-Review-1

What is the motivation of this patch? Please explain in the commit message.

-- 
To view, visit http://gerrit.ovirt.org/18329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has abandoned this change.

Change subject: Adding call to svdsm.ping from vdsm ping verb
......................................................................


Abandoned

Maybe it could be used for sanity tests when a user wants to check the communication to
vdsm and between vdsm to its related services, but then we should add ping to libvirt as
well. Anyhow, not so useful, and doesn't say much, so I pass.

-- 
To view, visit http://gerrit.ovirt.org/18329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ifc4caf642ce6d8281fa97f7f26ec39575304f339
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server