Change in vdsm[master]: Fixing call to setLinkAndNetwork after hook

Yaniv Bronhaim has uploaded a new change for review.

Change subject: Fixing call to setLinkAndNetwork after hook
......................................................................

Fixing call to setLinkAndNetwork after hook

The third parameter should be the params field

Change-Id: I9188c6862b19a2473f8cfc5f5d207b35ca8c8507
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M vdsm/vm.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/22884/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 6467e0e..cc602cd 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -3239,10 +3239,11 @@
                                             libvirt.VIR_DOMAIN_AFFECT_LIVE)
                 dev._deviceXML = vnicStrXML
                 self.log.debug("Nic has been updated:\n %s" % vnicStrXML)
-                hooks.after_update_device(vnicStrXML, self.conf, custom)
+                hooks.after_update_device(vnicStrXML, self.conf, params=custom)
             except Exception as e:
                 self.log.debug('Request failed: %s', vnicStrXML, exc_info=True)
-                hooks.after_update_device_fail(vnicStrXML, self.conf, custom)
+                hooks.after_update_device_fail(vnicStrXML, self.conf,
+                                               params=custom)
                 raise SetLinkAndNetworkError(e.message)
             yield
         except Exception:


-- 
To view, visit http://gerrit.ovirt.org/22884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9188c6862b19a2473f8cfc5f5d207b35ca8c8507
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

Assaf Muller has posted comments on this change.

Change subject: Fixing call to setLinkAndNetwork after hook
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/vm.py
Line 3237:                                                         custom)
Line 3238:                 self._dom.updateDeviceFlags(vnicStrXML,
Line 3239:                                             libvirt.VIR_DOMAIN_AFFECT_LIVE)
Line 3240:                 dev._deviceXML = vnicStrXML
Line 3241:                 self.log.debug("Nic has been updated:\n %s" %
vnicStrXML)
Well, if you're gonna use named parameters I guess it would make sense to use them all
the way... The 2nd parameter is named as well.
Line 3242:                 hooks.after_update_device(vnicStrXML, self.conf,
params=custom)
Line 3243:             except Exception as e:
Line 3244:                 self.log.debug('Request failed: %s', vnicStrXML,
exc_info=True)
Line 3245:                 hooks.after_update_device_fail(vnicStrXML, self.conf,


-- 
To view, visit http://gerrit.ovirt.org/22884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9188c6862b19a2473f8cfc5f5d207b35ca8c8507
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

Yaniv Bronhaim has abandoned this change.

Change subject: Fixing call to setLinkAndNetwork after hook
......................................................................


Abandoned

not relevant. my bad

-- 
To view, visit http://gerrit.ovirt.org/22884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I9188c6862b19a2473f8cfc5f5d207b35ca8c8507
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: Fixing call to setLinkAndNetwork after hook
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6488/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/5595/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6401/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/22884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9188c6862b19a2473f8cfc5f5d207b35ca8c8507
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No