11:18 a.m.
Igor Lvovsky has uploaded a new change for review.
Change subject: Introducing support of new parameter for VM create
......................................................................
Introducing support of new parameter for VM create
Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 39 insertions(+), 23 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/788/1
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
7:24 a.m.
New subject: Change in vdsm[master]: Support new type of vmParams parameter for VM create.
Igor Lvovsky has posted comments on this change.
Change subject: Support new type of vmParams parameter for VM create.
......................................................................
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:09 a.m.
New subject: Change in vdsm[master]: Support new type of vmParams parameter for VM create.
Dan Kenigsberg has posted comments on this change.
Change subject: Support new type of vmParams parameter for VM create.
......................................................................
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:09 a.m.
New subject: Change in vdsm[master]: Support new type of vmParams parameter for VM create.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Support new type of vmParams parameter for VM create.
......................................................................
Support new type of vmParams parameter for VM create.
- Normalize old vmParams to support new type that includes 'devices' key
- Return normalized conf including 'devices'
- Add new general Device class
- Add subclasses for each device: Drive, NetworkInterface, Sound, Video
Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
---
M vdsm/libvirtvm.py
M vdsm/vm.py
2 files changed, 404 insertions(+), 256 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
6:06 a.m.
New subject: Change in vdsm[master]: Support new type of vmParams parameter for VM create.
Dan Kenigsberg has posted comments on this change.
Change subject: Support new type of vmParams parameter for VM create.
......................................................................
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
5:01 a.m.
New subject: Change in vdsm[master]: Support new type of vmParams parameter for VM create.
Igor Lvovsky has posted comments on this change.
Change subject: Support new type of vmParams parameter for VM create.
......................................................................
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
7:40 a.m.
New subject: Change in vdsm[master]: Support new type of vmParams parameter for VM create.
Dan Kenigsberg has posted comments on this change.
Change subject: Support new type of vmParams parameter for VM create.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(9 inline comments)
minor style issues
....................................................
File vdsm/libvirtvm.py
Line 831: _VHOST_MAP = {'true': 'vhost', 'false':
'qemu'}
now _ prefix is redundant
Line 1089: devMap = {'drives': Drive, 'nic':
NetworkInterfaceDevice,
'drives' etc should better be CONSTANTS
Line 1092: for devType, devObj in devMap.items():
devObj -> devClass
....................................................
File vdsm/vm.py
Line 52: self.doc = xml.dom.minidom.Document()
please move to specific getXML functions
Line 349: removables = [{'type': 'disk', 'device':
'cdrom', 'path': self.conf.get('cdrom', ''),
long line
Line 362: if dev['type'] == 'disk':
nic->interface
drives->disk
and loose the elif.
Line 372: def buildConfDevices(self):
"""
Return the "devices" section of this Vm's conf. If missing, create it
according old API.
"""
Line 379: if confDevices == None:
no need for variable confDevices
Line 408: vcards.append({'type': 'video',
'specParams': vram, 'device': devType})
longline
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
11:23 a.m.
Igor Lvovsky has posted comments on this change.
Change subject: Introducing support of new parameter for VM create
......................................................................
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26a9bf46a23f5c6d92ea3fea163ac23dcac21df8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
4500
days inactive
4508
days old
vdsm-patches@lists.fedorahosted.org
7 comments
2 participants
participants (2)
-
Dan Kenigsberg -
Igor Lvovsky