Hello Adam Litke,
I'd like you to do a code review. Please visit
to review the following change.
Change subject: Add local storage xmlrpc functional test ......................................................................
Add local storage xmlrpc functional test
Add defintion parser for functional test case reusable, add local storage xmlrpc tests it can be extend to nfs and iscsi type
Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Signed-off-by: Royce Lv lvroyce@linux.vnet.ibm.com Signed-off-by: Adam Litke agl@us.ibm.com --- M configure.ac M tests/functional/Makefile.am A tests/functional/xmlrpcTests.py M vdsm.spec.in 4 files changed, 198 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/5860/1 -- To view, visit http://gerrit.ovirt.org/5860 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com
Royce Lv has posted comments on this change.
Change subject: Add local storage xmlrpc functional test ......................................................................
Patch Set 1:
Need to rebase on Dan's patch when it is merged
-- To view, visit http://gerrit.ovirt.org/5860 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com
Xu He Jie has posted comments on this change.
Change subject: Add local storage xmlrpc functional test ......................................................................
Patch Set 3: Verified
(2 inline comments)
minor comment
.................................................... File INSTALL Line 229: HP-UX `make' updates targets which have the same time stamps as I fix this at http://gerrit.ovirt.org/#/c/5945/
.................................................... File tests/functional/SampleDef/Makefile.am Line 21: vdsmfunctestsdefdir = ${vdsmtestsdir}/functional/SampleDef Why did you add this?
-- To view, visit http://gerrit.ovirt.org/5860 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com
Yaniv Bronhaim has posted comments on this change.
Change subject: Add local storage xmlrpc functional test ......................................................................
Patch Set 3:
i try to run those tests as developer (with make check). without running vdsm-bootstrap process i don't have ssl keys to talk with the engine. So i get this output: ERROR: Failure: Exception (No permission to read file: /etc/pki/vdsm/keys/vdsmkey.pem).
I think that unit tests don't suppose to rely on stable installation. if it is, it should be part of ruth.
You can add temp vdsmkey.pem for this test
-- To view, visit http://gerrit.ovirt.org/5860 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com
Yaniv Bronhaim has posted comments on this change.
Change subject: Add local storage xmlrpc functional test ......................................................................
Patch Set 3: Verified
over rhel6.3
-- To view, visit http://gerrit.ovirt.org/5860 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Yaniv Bronhaim has posted comments on this change.
Change subject: Add local storage xmlrpc functional test ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
.................................................... File tests/functional/xmlrpcTests.py Line 185: except Exception: Line 186: self._cleanupStorage(rollback) Line 187: raise Line 188: Line 189: @testValidation.ValidateRunningAsRoot This attribute doesn't work.. I ran it not as Root and it tried to run this test anyway Line 190: def testLocalStorage(self): Line 191: storageHandle = self._setupStorage()
-- To view, visit http://gerrit.ovirt.org/5860 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
Royce Lv has abandoned this change.
Change subject: Add local storage xmlrpc functional test ......................................................................
Patch Set 3: Abandoned
Zheng Sheng has take this part and patches merged
-- To view, visit http://gerrit.ovirt.org/5860 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon Gerrit-Change-Id: I4e2e80fa88d66d9bc1a4ba855e2df51ba8165e0a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Xu He Jie xuhj@linux.vnet.ibm.com Gerrit-Reviewer: Yaniv Bronhaim ybronhei@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshzhou@linux.vnet.ibm.com
vdsm-patches@lists.fedorahosted.org