mooli tayer has uploaded a new change for review.
Change subject: toolTests: Fix pyflakes error. ......................................................................
toolTests: Fix pyflakes error.
At change 32713 I introduced a pyflakes violation: ./tests/toolTests.py:309: undefined name 'Libvirt'
Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Signed-off-by: Mooli Tayer mtayer@redhat.com --- M tests/toolTests.py 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/33531/1
diff --git a/tests/toolTests.py b/tests/toolTests.py index 058c038..67d9f6b 100644 --- a/tests/toolTests.py +++ b/tests/toolTests.py @@ -306,7 +306,8 @@ with open(os.path.join(dirName, 'toolTests_%s.conf' % type_)) as template: data = template.read() - data = data % {'LATEST_CONF_VERSION': Libvirt.CONF_VERSION} + data = data % { + 'LATEST_CONF_VERSION': libvirt.Configurator.CONF_VERSION} with open(self.test_env[file_], 'w') as testConf: testConf.write(data)
Antoni Segura Puimedon has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1: Code-Review+1
Although I wouldn't say that it is to fix a pyflakes error, the code was erroneous before this patch.
Dan Kenigsberg has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1: Code-Review+2
This time, please apply more care to verification.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11729/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12673/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12518/ : SUCCESS
mooli tayer has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1: Verified+1
mooli tayer has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1: -Verified
one sec
mooli tayer has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1:
checking again.
mooli tayer has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1: Verified+1
Ran on fe20 and el6.4: make clean && make rpm NOSE_EXCLUDE=.*
On el6.4: clean checkout.
install rpms.
$ sudo vdsm-tool removeConf ... $ sudo cat /etc/libvirt/libvirtd.conf| grep -i vdsm $
$ sudo vdsm-tool configure --force $ sudo cat /etc/libvirt/libvirtd.conf| grep -i vdsm ## beginning of configuration section by vdsm-4.13.0 ca_file="/etc/pki/vdsm/certs/cacert.pem" cert_file="/etc/pki/vdsm/certs/vdsmcert.pem" key_file="/etc/pki/vdsm/keys/vdsmkey.pem" ## end of configuration section by vdsm-4.13.0
mooli tayer has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1:
NO NOSE_EXCLUDE.* !
mooli tayer has posted comments on this change.
Change subject: toolTests: Fix pyflakes error. ......................................................................
Patch Set 1:
@Antoni, not sure I understood. is this ok:
toolTests: Fix pyflakes violation introduced by 32713. ?
Dan Kenigsberg has submitted this change and it was merged.
Change subject: toolTests: Fix undefined name usage introduced by 32713. ......................................................................
toolTests: Fix undefined name usage introduced by 32713.
pyflakes complained: ./tests/toolTests.py:309: undefined name 'Libvirt'.
Change-Id: Ibb8fb3a8413d97d3ad6dca6ccbb81748facafe84 Signed-off-by: Mooli Tayer mtayer@redhat.com Reviewed-on: http://gerrit.ovirt.org/33531 Reviewed-by: Antoni Segura Puimedon asegurap@redhat.com Reviewed-by: Dan Kenigsberg danken@redhat.com --- M tests/toolTests.py 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve mooli tayer: Verified Dan Kenigsberg: Looks good to me, approved
oVirt Jenkins CI Server has posted comments on this change.
Change subject: toolTests: Fix undefined name usage introduced by 32713. ......................................................................
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/242/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5875/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4035/ : FAILURE
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/45/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/41/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/47/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/21/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: toolTests: Fix undefined name usage introduced by 32713. ......................................................................
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11733/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12677/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12522/ : SUCCESS
vdsm-patches@lists.fedorahosted.org