[NEW PATCH] Related to BZ#713173 - Add killProc rollback to deleteImage (via gerrit-bot)

[Igor Lvovsky]

New patch submitted by Igor Lvovsky (ilvovsky(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/707

commit ee4f07f9ed34f6db2aacdbc2678b4f20900ad761
Author: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Date:   Tue Jul 12 16:54:31 2011 +0300

    Related to BZ#713173 - Add killProc rollback to deleteImage
    
    Change-Id: I1407626ab06583f5507f3aaa8ebf2a4e4edd60f9

diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index 3da76fa..6b04047 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -261,7 +261,8 @@ class BlockVolume(volume.Volume):
                 # wipe out the whole volume
                 idle = config.getfloat('irs', 'idle')
                 try:
-                    misc.ddWatchCopy("/dev/zero", vol_path, vars.task.aborting,
idle, int(size))
+                    misc.ddWatchCopy("/dev/zero", vol_path, vars.task.aborting,
idle, int(size),
+                                     recoveryCallback=volume.baseAsyncTasksRollback)
                 except se.ActionStopped, e:
                     raise e
                 except Exception, e:

Change in vdsm[master]: Related to BZ#713173 - Add killProc rollback to deleteImage

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Related to BZ#713173 - Add killProc rollback to deleteImage
......................................................................


Related to BZ#713173 - Add killProc rollback to deleteImage

When we run deleteImage with post-zeroing flag, we need to issue 'dd' for this.
The rollback procedure for deleteImage it's actually roll forward.
In this situation we need first to kill previous 'dd' operation that may hold
file handler (or LV) open and prevent us to run the new deleteImage.
Note that in case we need to run this roll forward action on different host (SPM
switchover)
the 'dd' killing will do nothing and still may fail.

Change-Id: I1407626ab06583f5507f3aaa8ebf2a4e4edd60f9
---
M vdsm/storage/blockVolume.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.usersys.redhat.com/707
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1407626ab06583f5507f3aaa8ebf2a4e4edd60f9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Related to BZ#713173 - Add killProc rollback to deleteImage

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#713173 - Add killProc rollback to deleteImage
......................................................................


Patch Set 2: Verified; Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/707
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1407626ab06583f5507f3aaa8ebf2a4e4edd60f9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Related to BZ#713173 - Add killProc rollback to deleteImage

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Related to BZ#713173 - Add killProc rollback to deleteImage
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 8: 
please better explain what is this patch about and what does it solve. Why do we have to
explicitly kill the zeroing dd?

--
To view, visit http://gerrit.usersys.redhat.com/707
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1407626ab06583f5507f3aaa8ebf2a4e4edd60f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Related to BZ#713173 - Add killProc rollback to deleteImage

[David Naori]

David Naori has posted comments on this change.

Change subject: Related to BZ#713173 - Add killProc rollback to deleteImage
......................................................................


Patch Set 1:

Well it does not solve the bug, but it does solve the "cannot deactivate open logical
volume" issue by killing the dd process.

But in a situation of spm-failover this killProc is useless as we said.

--
To view, visit http://gerrit.usersys.redhat.com/707
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1407626ab06583f5507f3aaa8ebf2a4e4edd60f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;