Change in vdsm[ovirt-3.4]: RHEL7 works with systemd and requires systemd macros and tmp...

[Dan Kenigsberg]

Hello Yaniv Bronhaim,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/33021

to review the following change.

Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf
......................................................................

RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf

Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122198
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/30820
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/33021/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 7af6d59..8c5d31a 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -39,7 +39,7 @@
 %global with_systemd 1
 %endif
 
-%if 0%{?fedora} >= 18
+%if 0%{?fedora} >= 18 || 0%{?rhel} >= 7
 %global with_systemd_macros 1
 %global with_tmpfiles_macro 1
 %endif


-- 
To view, visit http://gerrit.ovirt.org/33021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-el6-x86_64_merged/3/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/73/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/287/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-el7-x86_64_merged/4/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-fc19-x86_64_merged/3/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-fc20-x86_64_merged/3/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/72/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/286/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-el6-x86_64_merged/2/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-el7-x86_64_merged/3/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-fc19-x86_64_merged/2/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms-fc20-x86_64_merged/2/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/33021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf
......................................................................


RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf

Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1122198
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/30820
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-on: http://gerrit.ovirt.org/33021
Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Tested-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Douglas Schilling Landgraf: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Dan Kenigsberg: Verified



-- 
To view, visit http://gerrit.ovirt.org/33021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

Yaniv Bronhaim has posted comments on this change.

Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/33021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf
......................................................................


Patch Set 1: Verified+1

# rpm -qpl /root/rpmbuild/RPMS/x86_64/vdsm-4.14.15-7.gite452f61.el7.centos.x86_64.rpm|grep
tmpfiles.d
/usr/lib/tmpfiles.d/vdsm.conf

-- 
To view, visit http://gerrit.ovirt.org/33021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Douglas Schilling Landgraf]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/33021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: RHEL7 works with systemd and requires systemd macros and tmpfiles.d conf
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/69/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/33021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176d1770fed745e1cf2cab45a55544ccdd6f25fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No