6:01 a.m.
New patch submitted by Federico Simoncelli (fsimonce(a)redhat.com)
You can review this change at: http://gerrit.usersys.redhat.com/861
commit 067f769de4df00cf4015e82acd16c1319938a14f
Author: Federico Simoncelli <fsimonce(a)redhat.com>
Date: Mon Aug 29 11:01:16 2011 +0000
BZ#732914 VDSM must exit if libvirt is not running
Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
diff --git a/vdsm/libvirtconnection.py b/vdsm/libvirtconnection.py
index 1585b87..4eee356 100644
--- a/vdsm/libvirtconnection.py
+++ b/vdsm/libvirtconnection.py
@@ -103,7 +103,12 @@ def get(cif=None):
conn = __connections.get(id(cif))
if not conn:
- conn = libvirt.openAuth('qemu:///system', auth, 0)
+ try:
+ conn = libvirt.openAuth('qemu:///system', auth, 0)
+ except libvirt.libvirtError:
+ cif.log.error('Unable to connect to libvirt, taking vdsm down.',
+ exc_info=True)
+ cif.prepareForShutdown()
__connections[id(cif)] = conn
if cif != None:
for ev in (libvirt.VIR_DOMAIN_EVENT_ID_LIFECYCLE,
7:37 a.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Igor Lvovsky has posted comments on this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11:24 a.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Federico Simoncelli has abandoned this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1: Abandoned
Replaced by: http://gerrit.usersys.redhat.com/896
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
1:10 p.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1: Fails
At the moment it's failing. Might need:
http://gerrit.usersys.redhat.com/863
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
6:50 p.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1:
Sorry, I didn't see your comment inline (probably a the page was cached). I understand
what you mean. I'll fix it.
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
6:49 p.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1:
Look at line 87, isn't it the same?
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
6:43 p.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1:
I think it is not nice to wait for
AttributeError: 'NoneType' object has no attribute 'bla'
but I guess it is not the end of the world.
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
6:40 p.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Federico Simoncelli has posted comments on this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1:
Dan why voting this -1? I read the bug description (including what David said), I
reproduced the problem, I verified that this patch is fixing it (as mentioned in the bug)
and I'm waiting for David to verify it.
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
6:14 p.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
David said he had problem with a similar fix.
....................................................
File vdsm/libvirtconnection.py
Line 119: conn.domainEventRegisterAny(None, ev, __eventCallback, (cif,
ev))
why should we continue? this would explode with NoneType.
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Naori <dnaori(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
8:22 a.m.
New subject: Change in vdsm[master]: BZ#732914 VDSM must exit if libvirt is not running
Saggi Mizrahi has posted comments on this change.
Change subject: BZ#732914 VDSM must exit if libvirt is not running
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
Looks good, please let some preinteg guy test it. Just because Danken is not here to give
a scholarly comment.
--
To view, visit http://gerrit.usersys.redhat.com/861
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I673184b8e5d765a9397f3fc14a70f7c31b907b3e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron(a)redhat.com>
4614
days inactive
4621
days old
vdsm-patches@lists.fedorahosted.org
9 comments
4 participants
participants (4)
-
Dan Kenigsberg -
Federico Simoncelli -
Igor Lvovsky -
smizrahi＠redhat.com