Change in vdsm[master]: sos: collect permissions of /etc/vdsm/

Lee Yarwood has uploaded a new change for review.

Change subject: sos: collect permissions of /etc/vdsm/
......................................................................

sos: collect permissions of /etc/vdsm/

sos is not correctly preserving permissions of collected
files (BZ#888724). Until this is fixed we need to gather
the output of ls -lR against /etc/vdsm.

Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=987931
Signed-off-by: Lee Yarwood <lyarwood(a)redhat.com&gt;
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/17287/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 63a028c..a62f305 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -81,6 +81,7 @@
             self.addCopySpec("/proc/%s/cmdline" % pid)
             self.addCopySpec("/proc/%s/status" % pid)
             self.addCopySpec("/proc/%s/mountstats" % pid)
+        self.collectExtOutput("/bin/ls -lR /etc/vdsm")
         self.collectExtOutput("/bin/ls -l /var/log/core")
         self.collectExtOutput(
             "/bin/su vdsm -s /bin/sh -c '/usr/bin/tree -l
@VDSMREPO@'")


-- 
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;

Lee Yarwood has abandoned this change.

Change subject: sos: collect permissions of /etc/vdsm/
......................................................................


Patch Set 1: Abandoned

-- 
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com&gt;
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: sos: collect permissions of /etc/vdsm/
......................................................................


Patch Set 1:

I do not understand how /etc/vdsm has lost its accessibility. Note that there are plenty
of other system paths which, when becoming inaccessible, render the host useless. Why are
we limiting ourselves to /etc/vdsm?

BTW, `ls -lRZ` may be useful to spot selinux misfortunes.

-- 
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com&gt;
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: sos: collect permissions of /etc/vdsm/
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I see that

 Bug 888724 - sos does not preserve permissions on collected files

is on the verge of being fixed. Wouldn't it be simpler and nicer to require the fixed
version in vdsm instead of pushing a cumbersome hack that is going to become obsolete very
soon?

-- 
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com&gt;
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Keith Robertson has posted comments on this change.

Change subject: sos: collect permissions of /etc/vdsm/
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

'ls' or 'stat' makes no difference to me.  Just throwing it out there.

....................................................
File vdsm/sos/vdsm.py.in
Line 80:             pid = line.strip()
Line 81:             self.addCopySpec("/proc/%s/cmdline" % pid)
Line 82:             self.addCopySpec("/proc/%s/status" % pid)
Line 83:             self.addCopySpec("/proc/%s/mountstats" % pid)
Line 84:         self.collectExtOutput("/bin/ls -lR /etc/vdsm")
This is fine.  However, the 'stat' command might be more useful.  Check this
out...


stat /etc/libvirt/
  File: `/etc/libvirt/'
  Size: 4096      	Blocks: 8          IO Block: 4096   directory
Device: fd00h/64768d	Inode: 545643      Links: 2
Access: (0755/drwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2013-07-17 16:12:10.326039581 -0400
Modify: 2013-07-17 21:07:03.328316933 -0400
Change: 2013-07-17 21:07:03.328316933 -0400
Line 85:         self.collectExtOutput("/bin/ls -l /var/log/core")
Line 86:         self.collectExtOutput(
Line 87:             "/bin/su vdsm -s /bin/sh -c '/usr/bin/tree -l
@VDSMREPO@'")
Line 88:         self.collectExtOutput(


-- 
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com&gt;
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: sos: collect permissions of /etc/vdsm/
......................................................................


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/2686/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3493/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3577/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com&gt;
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server

Lee Yarwood has posted comments on this change.

Change subject: sos: collect permissions of /etc/vdsm/
......................................................................


Patch Set 1: Verified

-- 
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com&gt;
Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com&gt;
Gerrit-Reviewer: humble devassy <hchiramm(a)redhat.com&gt;