Alon Bar-Lev has posted comments on this change.
Change subject: vdsClient: file based mechanism to provide password ......................................................................
Patch Set 1: Code-Review-1
Hi,
There is no need for base64.
CLI should support the following options, by order (first wins):
1. get password from cli a. file, the file should contain plain password. b. argument, weak, encouraged but we do not enforce our-selves.
2. get password from environment.
3. get password interactively (optional).
See a simple example at[1].
I kinda like the openssl[2] solution... to use --xxxx=file:xxx --xxxx=pass:xxx --xxxx=env:xxx but not that important, we can have two arguments.
Anyway, the base64 is not required.
Thanks!
[1] http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=packaging/bin/eng... [2] https://www.openssl.org/docs/apps/openssl.html
vdsm-patches@lists.fedorahosted.org