From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has uploaded a new change for review.
Change subject: check-merged: define a var as local ......................................................................
check-merged: define a var as local
bash's default is ugly. variables should be defined as local unless there's a good reason to expose them.
Change-Id: Ib8eeac6714fc7d540b3793f0fae33d1d8776deb4 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M automation/check-merged.sh 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/71697/1
diff --git a/automation/check-merged.sh b/automation/check-merged.sh index e06352b..32ef4a5 100755 --- a/automation/check-merged.sh +++ b/automation/check-merged.sh @@ -84,7 +84,7 @@
function run { mkdir "$EXPORTS"/lago-logs - failed=0 + local failed=0
lago start "$VM_NAME"
From Yaniv Bronhaim ybronhei@redhat.com:
Yaniv Bronhaim has posted comments on this change.
Change subject: check-merged: define a var as local ......................................................................
Patch Set 1: Code-Review+1
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: define a var as local ......................................................................
Patch Set 2: Code-Review+2 Verified+1
bash part is fine http://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/1212/consol...
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: check-merged: define a var as local ......................................................................
check-merged: define a var as local
bash's default is ugly. variables should be defined as local unless there's a good reason to expose them.
Change-Id: Ib8eeac6714fc7d540b3793f0fae33d1d8776deb4 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M automation/check-merged.sh 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved
vdsm-patches@lists.fedorahosted.org