Change in vdsm[master]: fix vdsm_reg makefile error

Royce Lv has uploaded a new change for review.

Change subject: fix vdsm_reg makefile error
......................................................................

fix vdsm_reg makefile error

register-to-engine was added to cleanup files,
and will cause error when autobuild

Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
---
M vdsm_reg/Makefile.am
M vdsm_reg/register-to-engine.py
2 files changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/4144/1
--
To view, visit http://gerrit.ovirt.org/4144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: fix vdsm_reg makefile error
......................................................................


fix vdsm_reg makefile error

register-to-engine was added to cleanup files,
and will cause error when autobuild

Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
---
M vdsm_reg/Makefile.am
1 file changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Xu He Jie: Looks good to me, but someone else must approve
  Bala.FA: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/4144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: fix vdsm_reg makefile error
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/4144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;

Bala.FA has posted comments on this change.

Change subject: fix vdsm_reg makefile error
......................................................................


Patch Set 2: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/4144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: fix vdsm_reg makefile error
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/4144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;

Bala.FA has posted comments on this change.

Change subject: fix vdsm_reg makefile error
......................................................................


Patch Set 1: I would prefer that you didn't submit this

--
To view, visit http://gerrit.ovirt.org/4144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;

Bala.FA has posted comments on this change.

Change subject: fix vdsm_reg makefile error
......................................................................


Patch Set 1: (1 inline comment)

I was above to send this fix, but I am reviewing now :-)

....................................................
File vdsm_reg/Makefile.am
Line 35: 	register-to-engine.py
Yes.  register-to-engine.py should be added into dist_vdsmreg_PYTHON and removed from
nodist_vdsmreg_PYTHON and EXTRA_DIST

--
To view, visit http://gerrit.ovirt.org/4144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;

[Xu He Jie]

Xu He Jie has posted comments on this change.

Change subject: fix vdsm_reg makefile error
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm_reg/Makefile.am
Line 35: 	register-to-engine.py
I think it should move to dist_vdsmreg_PYTHON

Line 65: 	register-to-engine.py \
remove from here

--
To view, visit http://gerrit.ovirt.org/4144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75130ff791c52fecc38a3afa8c5d99b7a512d508
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com&gt;
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com&gt;