[NEW PATCH] Fix new killall (via gerrit-bot)

New patch submitted by Saggi Mizrahi (smizrahi(a)redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/871

commit 3797a10d6e037eb39e6587ee5f0a4c3d65579009
Author: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Date:   Wed Aug 31 14:00:03 2011 +0300

    Fix new killall
    
    Change-Id: I42b7f49f4ca14b22d343b99763613700c246f33b

diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index b16df9b..247211d 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -1224,11 +1224,11 @@ class OperationMutex(object):
                 self._lock.release()
                 self._cond.notifyAll()
 
-def killall(signum, name, group=False):
+def killall(name, signum, group=False):
     exception = None
     knownPgs = set()
     pidList = pgrep(name)
-    if len(pidList):
+    if len(pidList) == 0:
         raise OSError(errno.ESRCH, "Could not find processes named `%s`" %
name)
 
     for pid in pidList:
@@ -1240,7 +1240,7 @@ def killall(signum, name, group=False):
                     continue
                 knownPgs.add(pgid)
 
-                os.killpg(pgid)
+                os.killpg(pgid, signum)
             else:
                 os.kill(pid, signum)
         except OSError, e:

Change in vdsm[master]: Fix new killall

[Haim Ateya]

Haim Ateya has posted comments on this change.

Change subject: Fix new killall
......................................................................


Patch Set 1: Verified

--
To view, visit http://gerrit.usersys.redhat.com/871
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b7f49f4ca14b22d343b99763613700c246f33b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;

Change in vdsm[master]: Fix new killall

Saggi Mizrahi has submitted this change and it was merged.

Change subject: Fix new killall
......................................................................


Fix new killall

Change-Id: I42b7f49f4ca14b22d343b99763613700c246f33b
---
M vdsm/storage/misc.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Igor Lvovsky: Looks good to me, but someone else must approve
  Haim Ateya: Verified
  Saggi Mizrahi: Looks good to me, approved


--
To view, visit http://gerrit.usersys.redhat.com/871
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42b7f49f4ca14b22d343b99763613700c246f33b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Fix new killall

Saggi Mizrahi has posted comments on this change.

Change subject: Fix new killall
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.usersys.redhat.com/871
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b7f49f4ca14b22d343b99763613700c246f33b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;

Change in vdsm[master]: Fix new killall

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: Fix new killall
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.usersys.redhat.com/871
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42b7f49f4ca14b22d343b99763613700c246f33b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;