Change in vdsm[ovirt-3.2]: schema: Missing comment for new VmDeviceType

Hello Adam Litke, Saggi Mizrahi,

I'd like you to do a code review.  Please visit

http://gerrit.ovirt.org/10020

to review the following change.

Change subject: schema: Missing comment for new VmDeviceType
......................................................................

schema: Missing comment for new VmDeviceType

When adding a new 'console' VmDeviceType, the submitter forgot to include
documentation in the comment block.  This caused process-schema.py to fail.

Change-Id: Icd7db71a4cd1a2addd31815a73dcd5c1cda7af4f
Signed-off-by: Adam Litke 
Reviewed-on: http://gerrit.ovirt.org/10013
Reviewed-by: Saggi Mizrahi 
Tested-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/10020/1

diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 9772e18..8f56df0 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -1681,6 +1681,8 @@
 #
 # @channel:     A host-guest communication channel
 #
+# @console:     A console device
+#
 # Since: 4.10.0
 ##
 {'enum': 'VmDeviceType',

--
To view, visit http://gerrit.ovirt.org/10020
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd7db71a4cd1a2addd31815a73dcd5c1cda7af4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Saggi Mizrahi

Adam Litke has posted comments on this change.

Change subject: schema: Missing comment for new VmDeviceType
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/10020
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd7db71a4cd1a2addd31815a73dcd5c1cda7af4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: schema: Missing comment for new VmDeviceType
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/10020
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd7db71a4cd1a2addd31815a73dcd5c1cda7af4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: schema: Missing comment for new VmDeviceType
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/10020
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd7db71a4cd1a2addd31815a73dcd5c1cda7af4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra

[Federico Simoncelli]

Federico Simoncelli has submitted this change and it was merged.

Change subject: schema: Missing comment for new VmDeviceType
......................................................................

schema: Missing comment for new VmDeviceType

When adding a new 'console' VmDeviceType, the submitter forgot to include
documentation in the comment block.  This caused process-schema.py to fail.

Change-Id: Icd7db71a4cd1a2addd31815a73dcd5c1cda7af4f
Signed-off-by: Adam Litke 
Reviewed-on: http://gerrit.ovirt.org/10013
Reviewed-by: Saggi Mizrahi 
Tested-by: Saggi Mizrahi 
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Looks good to me, but someone else must approve
  Federico Simoncelli: 
  Dan Kenigsberg: Verified; Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/10020
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd7db71a4cd1a2addd31815a73dcd5c1cda7af4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Antoni Segura Puimedon 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Vinzenz Feenstra