Martin Betak has uploaded a new change for review.
Change subject: caps.py: Drop support for Fedora 19 ......................................................................
caps.py: Drop support for Fedora 19
Change-Id: Ib1f89f3b8371b6d3f4ba8a4e17b454254213960d Signed-off-by: Martin Betak mbetak@redhat.com --- M vdsm/caps.py 1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/91/34191/1
diff --git a/vdsm/caps.py b/vdsm/caps.py index cf4967b..c419bd7 100644 --- a/vdsm/caps.py +++ b/vdsm/caps.py @@ -722,13 +722,6 @@
@utils.memoized def _getVersionInfo(): - if not hasattr(libvirt, 'VIR_MIGRATE_ABORT_ON_ERROR'): - return _dropVersion('3.4', - 'VIR_MIGRATE_ABORT_ON_ERROR not found in libvirt,' - ' support for clusterLevel >= 3.4 is disabled.' - ' For Fedora 19 users, please consider upgrading' - ' libvirt from the virt-preview repository') - if not hasattr(libvirt, 'VIR_MIGRATE_AUTO_CONVERGE'): return _dropVersion('3.6', 'VIR_MIGRATE_AUTO_CONVERGE not found in libvirt,'
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps.py: Drop support for Fedora 19 ......................................................................
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12972/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12814/ : SUCCESS
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/12023/ : FAILURE
Martin Betak has posted comments on this change.
Change subject: caps.py: Drop support for Fedora 19 ......................................................................
Patch Set 1: Verified+1
Dan Kenigsberg has posted comments on this change.
Change subject: caps.py: Drop support for Fedora 19 ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/34191/1//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2014-10-15 15:03:31 +0200 Line 4: Commit: Martin Betak mbetak@redhat.com Line 5: CommitDate: 2014-10-15 15:03:31 +0200 Line 6: Line 7: caps.py: Drop support for Fedora 19 please include an explicit hard requirement for a libvirt version with VIR_MIGRATE_ABORT_ON_ERROR in the spec file.
Dropping other reference to Fedora 19 from the spec would be a nice bonus. Line 8: Line 9: Change-Id: Ib1f89f3b8371b6d3f4ba8a4e17b454254213960d
Francesco Romani has posted comments on this change.
Change subject: caps.py: Drop support for Fedora 19 ......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34191/1//COMMIT_MSG Commit Message:
Line 3: AuthorDate: 2014-10-15 15:03:31 +0200 Line 4: Commit: Martin Betak mbetak@redhat.com Line 5: CommitDate: 2014-10-15 15:03:31 +0200 Line 6: Line 7: caps.py: Drop support for Fedora 19
please include an explicit hard requirement for a libvirt version with VIR_
I think your first remark is already addressed by 63b42ea67a79c6cebce276a8ae2b69074d0dba11 Line 8: Line 9: Change-Id: Ib1f89f3b8371b6d3f4ba8a4e17b454254213960d
Michal Skrivanek has posted comments on this change.
Change subject: caps.py: Drop support for Fedora 19 ......................................................................
Patch Set 1: Code-Review+1
looks good to go? or what other F19 references you mean?
vdsm-patches@lists.fedorahosted.org