Dan Kenigsberg has uploaded a new change for review.
Change subject: have an empty lastClient on xmlrpc startup ......................................................................
have an empty lastClient on xmlrpc startup
Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba --- M vdsm/BindingXMLRPC.py 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/1637/1 -- To view, visit http://gerrit.ovirt.org/1637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: have an empty lastClient on xmlrpc startup ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/1637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Douglas Schilling Landgraf has posted comments on this change.
Change subject: have an empty lastClient on xmlrpc startup ......................................................................
Patch Set 1: Verified
This patch will avoid this error message:
Thread-426::ERROR::2012-02-06 22:29:26,663::BindingXMLRPC::841::vds::(wrapper) Traceback (most recent call last): File "/usr/share/vdsm/BindingXMLRPC.py", line 831, in wrapper res = f(*args, **kwargs) File "/usr/share/vdsm/BindingXMLRPC.py", line 264, in getCapabilities ret['info'].update(self.getServerInfo()) File "/usr/share/vdsm/BindingXMLRPC.py", line 90, in getServerInfo last = self.server.lastClient AttributeError: SecureThreadedXMLRPCServer instance has no attribute 'lastClient'
-- To view, visit http://gerrit.ovirt.org/1637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: have an empty lastClient on xmlrpc startup ......................................................................
Patch Set 1: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: have an empty lastClient on xmlrpc startup ......................................................................
Patch Set 2: Verified; Looks good to me, approved
rebased
-- To view, visit http://gerrit.ovirt.org/1637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
Dan Kenigsberg has submitted this change and it was merged.
Change subject: have an empty lastClient on xmlrpc startup ......................................................................
have an empty lastClient on xmlrpc startup
Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba --- M vdsm/BindingXMLRPC.py 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: Dan Kenigsberg: Verified; Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/1637 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I8392f299550f68a1d33d6a5be4f36b8880f048ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsland@redhat.com
vdsm-patches@lists.fedorahosted.org