Change in vdsm[master]: configNet: atomicBackup: remove new files upon restore

[Dan Kenigsberg]

Dan Kenigsberg has uploaded a new change for review.

Change subject: configNet: atomicBackup: remove new files upon restore
......................................................................

configNet: atomicBackup: remove new files upon restore

Files that are created by ConfigWriter._atomicBackup() should be removed
by restoreAtomicBackup, not forgotten on disk.

This patch also adds a unit test for _atomicBackup.

Change-Id: I66bdb20b6e7e78be198f2616aa0ef7a8efeec18a
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M tests/configNetworkTests.py
M vdsm/configNetwork.py
2 files changed, 58 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/5952/1
--
To view, visit http://gerrit.ovirt.org/5952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66bdb20b6e7e78be198f2616aa0ef7a8efeec18a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: configNet: atomicBackup: remove new files upon restore
......................................................................


configNet: atomicBackup: remove new files upon restore

Files that are created by ConfigWriter._atomicBackup() should be removed
by restoreAtomicBackup, not forgotten on disk.

Change-Id: I66bdb20b6e7e78be198f2616aa0ef7a8efeec18a
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com&gt;
---
M vdsm/configNetwork.py
1 file changed, 10 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Verified
  Igor Lvovsky: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66bdb20b6e7e78be198f2616aa0ef7a8efeec18a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: configNet: atomicBackup: remove new files upon restore
......................................................................


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/5952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66bdb20b6e7e78be198f2616aa0ef7a8efeec18a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: configNet: atomicBackup: remove new files upon restore
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/5952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66bdb20b6e7e78be198f2616aa0ef7a8efeec18a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;

[Igor Lvovsky]

Igor Lvovsky has posted comments on this change.

Change subject: configNet: atomicBackup: remove new files upon restore
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Ack for patch itself.
But, you should split out the test to different patch,
because I can't take it like this to downstream

--
To view, visit http://gerrit.ovirt.org/5952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66bdb20b6e7e78be198f2616aa0ef7a8efeec18a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com&gt;