Piotr Kliczewski has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures ......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/65294/8/tests/utilsTests.py File tests/utilsTests.py:
Line 132: self.check_failure() Line 133: Line 134: def test_kill_failure(self): Line 135: def fail(): Line 136: raise ExpectedFailure("Fake kill failure")
3 test, 3 fail texts, please suggest a simple and more clear code.
Why not to have fail method as top level and use it 138 and in 145 line. We do not need to have it in two places. Line 137: Line 138: self.proc.kill = fail Line 139: self.check_failure() Line 140:
vdsm-patches@lists.fedorahosted.org