Douglas Schilling Landgraf has posted comments on this change.
Change subject: improve add/del bridgesless network
......................................................................
Patch Set 4: (2 inline comments)
....................................................
Commit Message
Line 7: improve add/del bridgesless network
Yes, I have follow Dan's suggestion to use the skipLibvirt approach and I have figure
out a better solution.
....................................................
File vdsm/configNetwork.py
Line 706: def delNetwork(network, vlan=None, bonding=None, nics=None, force=False,
configWriter=None, **options):
have you checked that no one calling delNetwork and passing args by
order?
Yes. I will prepare a second patch to improve it too.
please avoid adding long lines.
OK
--
To view, visit
http://gerrit.ovirt.org/3615
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f170eaced2d6f756b84cb52e9efce6dc9722405
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>