Doron Fediuck has uploaded a new change for review.
Change subject: boostrap completion: fix no reboot report. ......................................................................
boostrap completion: fix no reboot report.
This patch fixes the vds_bootsrap_complete XML report; when the script is being asked not to reboot the machine, so the operation is still considered to be a success.
Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb --- M vds_bootstrap/vds_bootstrap_complete.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/2121/1 -- To view, visit http://gerrit.ovirt.org/2121 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Doron Fediuck dfediuck@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: boostrap completion: fix no reboot function and report. ......................................................................
Patch Set 2: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/2121 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com
Roy Golan has posted comments on this change.
Change subject: boostrap completion: fix no reboot function and report. ......................................................................
Patch Set 2: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2121 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com
Roy Golan has posted comments on this change.
Change subject: boostrap completion: fix no reboot function and report. ......................................................................
Patch Set 2: Verified
-- To view, visit http://gerrit.ovirt.org/2121 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com
Federico Simoncelli has submitted this change and it was merged.
Change subject: boostrap completion: fix no reboot function and report. ......................................................................
boostrap completion: fix no reboot function and report.
This patch fixes the functionality of no reboot as a given argument to the script. So using 0 will avoid rebooting and anything else will continue rebooting as it did so far.
Additionaly the vds_bootsrap_complete XML report was corrected; when the script is being asked not to reboot the machine, so the operation is still considered to be a success.
Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb --- M vds_bootstrap/vds_bootstrap_complete.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Federico Simoncelli: Dan Kenigsberg: Looks good to me, approved Roy Golan: Verified; Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2121 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I89c441fb999c696f60e1ed3172c0ed57649e78bb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Doron Fediuck dfediuck@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Roy Golan rgolan@redhat.com
vdsm-patches@lists.fedorahosted.org