3:39 a.m.
Dan Kenigsberg has uploaded a new change for review.
Change subject: libvirtvm: unsetPortMirroring just before hotunplug
......................................................................
libvirtvm: unsetPortMirroring just before hotunplug
Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/libvirtvm.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/7425/1
diff --git a/vdsm/libvirtvm.py b/vdsm/libvirtvm.py
index acc9399..e3d8915 100644
--- a/vdsm/libvirtvm.py
+++ b/vdsm/libvirtvm.py
@@ -1436,6 +1436,10 @@
break
if nic:
+ if hasattr(nic, 'portMirroring'):
+ for network in nic.portMirroring:
+ supervdsm.getProxy().unsetPortMirroring(network, nic.name)
+
nicXml = nic.getXML().toprettyxml(encoding='utf-8')
self.log.debug("Hotunplug NIC xml: %s", nicXml)
else:
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6:48 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
Dan Kenigsberg has submitted this change and it was merged.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
libvirtvm: (un)setPortMirroring when hot(un)plugging
Bug-Id: https://bugzilla.redhat.com/848101
Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/libvirtvm.py
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Dan Kenigsberg: Verified
Igor Lvovsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:48 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
Dan Kenigsberg has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 7: Verified
Verified that vdsm responds to verb. However tying the loop depends on Engine bug
https://bugzilla.redhat.com/show_bug.cgi?id=853709
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
6:34 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
Igor Lvovsky has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:44 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/803/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:36 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
Antoni Segura Puimedon has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
5:13 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
Igor Lvovsky has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:44 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
Antoni Segura Puimedon has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
Continues to look good to me as it is just a rebase.
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
1:23 p.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/782/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10:22 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
Antoni Segura Puimedon has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
7:42 a.m.
New subject: Change in vdsm[master]: libvirtvm: (un)setPortMirroring when hot(un)plugging
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtvm: (un)setPortMirroring when hot(un)plugging
......................................................................
Patch Set 4:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/717/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
3:35 a.m.
Dan Kenigsberg has posted comments on this change.
Change subject: libvirtvm: unsetPortMirroring just before hotunplug
......................................................................
Patch Set 3: I would prefer that you didn't submit this
Igor: must add symmetric setPortMirroring on hotplug!
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
9:26 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtvm: unsetPortMirroring just before hotunplug
......................................................................
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/629/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4:42 a.m.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libvirtvm: unsetPortMirroring just before hotunplug
......................................................................
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/615/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/7425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c4ae92d5beb4b7eec08912aae5e2ba4761a7248
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
4105
days inactive
4115
days old
vdsm-patches@lists.fedorahosted.org
13 comments
4 participants
participants (4)
-
asegurap＠redhat.com -
Dan Kenigsberg -
Igor Lvovsky -
Jenkins CI RO