Change in vdsm[master]: jsonrpc: regression on setupNetworks

[Piotr Kliczewski]

Piotr Kliczewski has uploaded a new change for review.

Change subject: jsonrpc: regression on setupNetworks
......................................................................

jsonrpc: regression on setupNetworks

During schema and code alignemnt Host_setupNetowrks entry was removed
from command_info. Adding back the entry and fixing schema verification
test.


Bug-Url: https://bugzilla.redhat.com/1178536
Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com&gt;
---
M tests/schemaValidationTest.py
M vdsm/rpc/Bridge.py
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/36612/1

diff --git a/tests/schemaValidationTest.py b/tests/schemaValidationTest.py
index d995a7f..43e061e 100644
--- a/tests/schemaValidationTest.py
+++ b/tests/schemaValidationTest.py
@@ -125,6 +125,8 @@
                     ret_info = Bridge.command_info.get(cmd, {}).get('ret')
                     if not ret_info and not ret:
                         continue
+                    if ret_info == 'status':
+                        continue
                     if not ret_info or not ret:
                         raise AssertionError('wrong return type for ' + cmd)
                 except KeyError:
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index f8c06f6..f1f6f31 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -418,6 +418,7 @@
     'Host_getVMList': {'call': Host_getVMList_Call, 'ret':
Host_getVMList_Ret},
     'Host_getVMFullList': {'call': Host_getVMFullList_Call,
'ret': 'vmList'},
     'Host_getAllVmStats': {'ret': 'statsList'},
+    'Host_setupNetworks': {'ret': 'status'},
     'Image_cloneStructure': {'ret': 'uuid'},
     'Image_delete': {'ret': 'uuid'},
     'Image_deleteVolumes': {'ret': 'uuid'},


-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: jsonrpc: regression on setupNetworks
......................................................................


Patch Set 1:

* Update tracker::#1178536::OK
* Check Bug-Url::OK
* Check Public Bug::#1178536::OK, public bug
* Check Product::#1178536::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5',
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Oved Ourfali]

Oved Ourfali has posted comments on this change.

Change subject: jsonrpc: regression on setupNetworks
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: regression on setupNetworks
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: jsonrpc: regression on setupNetworks
......................................................................


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14796/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/14628/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13840/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

Dima Kuznetsov has posted comments on this change.

Change subject: jsonrpc: regression on setupNetworks
......................................................................


Patch Set 1: Verified+1 Code-Review+1

This works for me, added host to to engine, setup networks completed successfully.

Engine log:
http://jenkins.ovirt.org/job/ovirt_integration-test-poc_created/ws/old_en...

-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpc: regression on setupNetworks
......................................................................


jsonrpc: regression on setupNetworks

During schema and code alignemnt Host_setupNetowrks entry was removed
from command_info. Adding back the entry and fixing schema verification
test.


Bug-Url: https://bugzilla.redhat.com/1178536
Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com&gt;
Reviewed-on: http://gerrit.ovirt.org/36612
Reviewed-by: Oved Ourfali <oourfali(a)redhat.com&gt;
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com&gt;
Reviewed-by: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Tested-by: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
---
M tests/schemaValidationTest.py
M vdsm/rpc/Bridge.py
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Dima Kuznetsov: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server

automation(a)ovirt.org has posted comments on this change.

Change subject: jsonrpc: regression on setupNetworks
......................................................................


Patch Set 2:

* Update tracker::#1178536::OK
* Check TR::#1178536::ERROR, --- should not match .*

-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[Jenkins CI RO]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: jsonrpc: regression on setupNetworks
......................................................................


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6264/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/443/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/441/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/434/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/418/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_... :
FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64... :
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4429/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No