Change in vdsm[ovirt-3.5]: netlink: fix PEP8 missing line in netlink memory leak patch

Petr Horáček has uploaded a new change for review.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................

netlink: fix PEP8 missing line in netlink memory leak patch

Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Bug-Url: https://bugzilla.redhat.com/1158108
Signed-off-by: Petr Horáček <phoracek(a)redhat.com&gt;
---
M lib/vdsm/netlink.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/40488/1

diff --git a/lib/vdsm/netlink.py b/lib/vdsm/netlink.py
index 8aae2e5..caed7b5 100644
--- a/lib/vdsm/netlink.py
+++ b/lib/vdsm/netlink.py
@@ -68,6 +68,7 @@
             _rtnl_link_put(link)
             return link_info
 
+
 class NLSocketPool(object):
     """Pool of netlink sockets."""
     def __init__(self, size):


-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;

automation(a)ovirt.org has posted comments on this change.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................


Patch Set 1:

* Update tracker::#1158108::OK
* Check Bug-Url::OK
* Check Public Bug::#1158108::OK, public bug
* Check Product::#1158108::OK, Correct product oVirt
* Check TR::#1158108::OK, correct target release 3.5.3
* warn_if_not_merged_to_previous_branch: OK

-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Darshan N has posted comments on this change.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Petr Horáček has posted comments on this change.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................


Patch Set 1: Verified+1

Fixed PEP8 error 'E302 expected 2 blank lines' introduced here
https://gerrit.ovirt.org/#/c/40134/

-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Darshan N has posted comments on this change.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................


Patch Set 1:

With this fix build is going through for me. Pep8 version:
python-pep8-1.5.6-1.fc20.noarch

-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Darshan N has posted comments on this change.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Yaniv Bronhaim has posted comments on this change.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................


netlink: fix PEP8 missing line in netlink memory leak patch

Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Bug-Url: https://bugzilla.redhat.com/1158108
Signed-off-by: Petr Horáček <phoracek(a)redhat.com&gt;
Reviewed-on: https://gerrit.ovirt.org/40488
Reviewed-by: Darshan N <dnarayan(a)redhat.com&gt;
Tested-by: Darshan N <dnarayan(a)redhat.com&gt;
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
---
M lib/vdsm/netlink.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Petr Horáček: Verified
  Darshan N: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org

automation(a)ovirt.org has posted comments on this change.

Change subject: netlink: fix PEP8 missing line in netlink memory leak patch
......................................................................


Patch Set 2:

* Update tracker::#1158108::OK
* Check TR::#1158108::OK
* Set MODIFIED::bug 1158108::::#1158108::::OK

-- 
To view, visit https://gerrit.ovirt.org/40488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I659123c9e1f18e6ecb887f3eb59123acd986217a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No