Change in vdsm[master]: Flip execCmd default to sudo=False

Ewoud Kohl van Wijngaarden has uploaded a new change for review.

Change subject: Flip execCmd default to sudo=False
......................................................................

Flip execCmd default to sudo=False

Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
---
M vdsm/guestIF.py
M vdsm/libvirtvm.py
M vdsm/storage/blockSD.py
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
M vdsm/storage/lvm.py
M vdsm/storage/misc.py
M vdsm/storage/multipath.py
M vdsm/storage/safelease.py
M vdsm/supervdsm.py
10 files changed, 50 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/1926/1
--
To view, visit http://gerrit.ovirt.org/1926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;

[Dan Kenigsberg]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Flip execCmd default to sudo=False
......................................................................


Flip execCmd default to sudo=False

Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
---
M vdsm/guestIF.py
M vdsm/libvirtvm.py
M vdsm/storage/blockSD.py
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
M vdsm/storage/lvm.py
M vdsm/storage/misc.py
M vdsm/storage/multipath.py
M vdsm/storage/safelease.py
M vdsm/supervdsm.py
10 files changed, 50 insertions(+), 41 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Peter V. Saveliev: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/1926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Flip execCmd default to sudo=False
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.ovirt.org/1926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;

Peter V. Saveliev has posted comments on this change.

Change subject: Flip execCmd default to sudo=False
......................................................................


Patch Set 1: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/1926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com&gt;

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Flip execCmd default to sudo=False
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

ahh, it is painful to see all these sins in one patch!
(which requires serious testing...)

Could you add yourself to AUTHORS?

--
To view, visit http://gerrit.ovirt.org/1926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie931c704916ad44aa889ac097d08ff3b79926a1d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;