Federico Simoncelli has uploaded a new change for review.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Support the quiesce flag during a live snapshot
Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d --- M vdsm.spec.in M vdsm/libvirtvm.py 2 files changed, 38 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/2223/1 -- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com
Igor Lvovsky has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
-1 for visibility
.................................................... File vdsm/libvirtvm.py Line 1699: if hasattr(libvirt, "VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE"): do we REALLY want to get into these checks? I prefer requiring a newer version of libvirt.
Unlike libvirt, we cannot afford trying to support every version of every tool. Thought?
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 1: (1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1699: if hasattr(libvirt, "VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE"): I require a new version of libvirt (check vdsm.spec.in), but the problem is syncing with Fedora, the options are:
1) We wait for the support of quiesce in Fedora 2) We always fail on Fedora 3) We patch the Fedora RPM 4) We require a version that is not in Fedora yet (only rawhide probably)
What is wrong with checking capabilities, I don't see how this is going to make it more complex. Between "trying to support every version of every tool" (which is not what I am doing) and "using only the rpm requirements to get new capabilities" there's a sweet spot.
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 1: Looks good to me, but someone else must approve
The only thing I'm not sure of retry after failure with quiesce. Can we getCaps from guestAgent to know whether this is at all supported and not even try if it is not? (not just if libvirt supports it, but if the guest supports it). I'd rather avoid the error in the log and the wasted time in case there is no guest agent support for this. In addition, if there is ga support, I'm not sure the correct behaviour is to retry without it (even though this is what I told Federico).
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Dan Kenigsberg has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 1: No score
(1 inline comment)
.................................................... File vdsm/libvirtvm.py Line 1699: if hasattr(libvirt, "VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE"): My favourite is 4 + wait until this is available in Fedora.
But I can swallow this run-time check. I do not believe that almost 4 months have passed!
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Ayal Baron has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
.................................................... File vdsm/libvirtvm.py Line 1794: and type(e) == libvirt.libvirtError): can't we check the specific error in case quiesce failed?
Line 1813: break how can management differentiate between a snapshot that was taken with quiesce and one that was not?
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 3: (2 inline comments)
.................................................... File vdsm/libvirtvm.py Line 1794: and type(e) == libvirt.libvirtError): libvirt uses two generic errors in this case: VIR_ERR_INTERNAL_ERROR and VIR_ERR_ARGUMENT_UNSUPPORTED (which are used in many other cases)
Line 1813: break Done
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
Federico Simoncelli has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 4: Verified
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 5: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/47/
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 5:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/47/ : SUCCESS
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Ayal Baron has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Patch Set 5: Looks good to me, approved
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Support the quiesce flag during a live snapshot ......................................................................
Support the quiesce flag during a live snapshot
Signed-off-by: Federico Simoncelli fsimonce@redhat.com Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d --- M vdsm/libvirtvm.py 1 file changed, 41 insertions(+), 13 deletions(-)
Approvals: Ayal Baron: Looks good to me, approved Leonid Natapov: Verified Dan Kenigsberg:
-- To view, visit http://gerrit.ovirt.org/2223 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged Gerrit-Change-Id: I61c7c89fb42afa627b3e45cd74af03e032452a7d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Ayal Baron abaron@redhat.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimonce@redhat.com Gerrit-Reviewer: Igor Lvovsky ilvovsky@redhat.com Gerrit-Reviewer: Leonid Natapov leonidnatapov@gmail.com Gerrit-Reviewer: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server
vdsm-patches@lists.fedorahosted.org