Dan Kenigsberg has uploaded a new change for review.
Change subject: spbackends: simplify over-general evaluation ......................................................................
spbackends: simplify over-general evaluation
The removed code is too clever for the use case of only two values.
Change-Id: I775c4a6003a03c6b65bee3abc8559a88e3eaec01 Signed-off-by: Dan Kenigsberg danken@redhat.com --- M vdsm/storage/spbackends.py 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/41253/1
diff --git a/vdsm/storage/spbackends.py b/vdsm/storage/spbackends.py index 953e01e..f6ce02b 100644 --- a/vdsm/storage/spbackends.py +++ b/vdsm/storage/spbackends.py @@ -229,8 +229,11 @@
def setSpmStatus(self, lVer=None, spmId=None): self.invalidateMetadata() - metaParams = dict(filter(lambda kv: kv[1] is not None, - ((PMDK_LVER, lVer), (PMDK_SPM_ID, spmId)))) + metaParams = {} + if lVer is not None: + metaParams[PMDK_LVER] = lVer + if spmId is not None: + metaParams[PMDK_SPM_ID] = spmId self._metadata.update(metaParams)
@unsecured
automation@ovirt.org has posted comments on this change.
Change subject: spbackends: simplify over-general evaluation ......................................................................
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])
Nir Soffer has posted comments on this change.
Change subject: spbackends: simplify over-general evaluation ......................................................................
Patch Set 1: Code-Review+1
Thanks
Jenkins CI RO has abandoned this change.
Change subject: spbackends: simplify over-general evaluation ......................................................................
Abandoned
Abandoned due to no activity - please restore if still relevant
gerrit-hooks has posted comments on this change.
Change subject: spbackends: simplify over-general evaluation ......................................................................
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
Nir Soffer has restored this change.
Change subject: spbackends: simplify over-general evaluation ......................................................................
Restored
From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: spbackends: simplify over-general evaluation ......................................................................
Patch Set 6: Verified+1
setSpmStatus works fine, hosts with this patch are elected for SPM.
vdsm-patches@lists.fedorahosted.org